[CWS] add ubuntu 22.04 to functional tests #11764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcacheux
force-pushed
the
paulcacheux/ubuntu2204-aws
branch
from
38d6ebf to
ba9d49c
Compare
paulcacheux
force-pushed
the
paulcacheux/ubuntu2204-aws
branch
from
d8faf96 to
2130066
Compare
albertvaka
approved these changes
Apr 25, 2022
|
Looking at https://gitlab.ddbuild.io/DataDog/datadog-agent/-/pipelines/7778576 all kitchen tests are passing except the windows ones, but with failure similar to the ones found on the main branch (for example https://gitlab.ddbuild.io/DataDog/datadog-agent/-/pipelines/7777411) |
|
Should be good to merge then :) |
|
Oh, wait, it seems this broke some things here: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/131913499 |
|
@paulcacheux I think we will have to revert 😓 |
albertvaka
added a commit
that referenced
this pull request
Apr 25, 2022
This reverts commit f05e14c.
albertvaka
added a commit
that referenced
this pull request
Apr 25, 2022
This was referenced Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds an
ubuntu-22-04entry to CWS functional tests. Because ubuntu 22.04 ssh server doesn't acceptssh-rsakeys by default, this PR also removes the ssh key creation from kitchen setup and lets the different kitchen provider to manage those keys themselves (this is needed since just adding the platforms entry was failing with ssh failed error).Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.