-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[corechecks/snmp] Fix format config for column metric tags #11746
Conversation
@@ -90,64 +86,6 @@ type MetricsConfig struct { | |||
Options MetricsConfigOption `yaml:"options"` | |||
} | |||
|
|||
// GetTags retrieve tags using the metric config and values | |||
func (mtcl MetricTagConfigList) GetTags(fullIndex string, values *valuestore.ResultValueStore) []string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewers: GetTags has been moved to report_utils.go and renamed to getTagsFromMetricTagConfigList
Same for transformIndex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure I understood this PR correctly, there is some refactoring but the only real change in behavior is that we now use getColumnValuesFromSymbol
in the function getTagsFromMetricTagConfigList
instead of using values.GetColumnValues
?
Can you confirm my understanding is correct and I haven't missed any other change in the refactor?
@FlorianVeaux Your understanding is correct. Sorry, I should have detailed that in the first place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly a refactor and test, the one-line behavior change looks good to me if CI is green 👍
Thanks!
What does this PR do?
Fix format config to work with column metrics tags.
For example: https://github.com/DataDog/integrations-core/pull/11871/files#diff-7031715b315cd7cb4e97c40e1d0325fb47b864e970868d6c4b5438e9b9602bf2R27-R31
Motivation
1/ bug fix for #11557
2/ needed for DataDog/integrations-core#11871
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triage
milestone is set.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.team/..
label has been applied, indicating the team(s) that should QA this change.need-change/operator
andneed-change/helm
labels have been applied.