Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless] bump integration test dependencies #11622

Merged
merged 3 commits into from
Apr 18, 2022
Merged

Conversation

maxday
Copy link
Contributor

@maxday maxday commented Apr 11, 2022

What does this PR do?

Bump fasthttp

Motivation

Ever greening

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the config template has been updated.

@maxday maxday added this to the Triage milestone Apr 11, 2022
@maxday maxday requested a review from a team as a code owner April 11, 2022 16:32
@@ -73,7 +73,7 @@ func main() {
os.Exit(-1)
}

// handle SIGTERM
// handle SIGTERM signal
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change to trigger integration tests

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it applies here but usually when I need to commit something to trigger the CI I run a 'git commit --allow-empty' to push an empty commit.

Copy link
Contributor Author

@maxday maxday Apr 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but this does not apply there.
We trigger integration on serverless only if specific files are touched ( see : https://github.com/DataDog/datadog-agent/blob/main/.github/workflows/serverless-integration.yml#L5 )
I think this is about the change and we will run integration tests on all commits in a near future

@maxday maxday changed the title [Serverless] bump fasthttp in integration tests [WIP][Serverless] bump fasthttp in integration tests Apr 11, 2022
@maxday maxday force-pushed the maxday/update-fasthttp branch from bcb8d01 to b72c2da Compare April 11, 2022 16:54
@maxday maxday changed the title [WIP][Serverless] bump fasthttp in integration tests [Serverless] bump fasthttp in integration tests Apr 12, 2022
@maxday maxday changed the title [Serverless] bump fasthttp in integration tests [Serverless] bump integration test dependencies Apr 12, 2022
Copy link
Contributor

@IvanTopolcic IvanTopolcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxday maxday merged commit 558487f into main Apr 18, 2022
@maxday maxday deleted the maxday/update-fasthttp branch April 18, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants