-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serverless] bump integration test dependencies #11622
Conversation
@@ -73,7 +73,7 @@ func main() { | |||
os.Exit(-1) | |||
} | |||
|
|||
// handle SIGTERM | |||
// handle SIGTERM signal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small change to trigger integration tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it applies here but usually when I need to commit something to trigger the CI I run a 'git commit --allow-empty' to push an empty commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but this does not apply there.
We trigger integration on serverless only if specific files are touched ( see : https://github.com/DataDog/datadog-agent/blob/main/.github/workflows/serverless-integration.yml#L5 )
I think this is about the change and we will run integration tests on all commits in a near future
bcb8d01
to
b72c2da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
Bump fasthttp
Motivation
Ever greening
Reviewer's Checklist
Triage
milestone is set.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.team/..
label has been applied, indicating the team(s) that should QA this change.need-change/operator
andneed-change/helm
labels have been applied.