Skip to content

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Apr 8, 2022

What does this PR do?

Remove skip-dirs exclusion rules from .golanci-lint.yml.

Motivation

After this, we can remove all the manual Go linters 🎉

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the config template has been updated.

@mx-psi mx-psi added changelog/no-changelog [deprecated] team/agent-platform [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card labels Apr 8, 2022
@mx-psi mx-psi added this to the 7.37.0 milestone Apr 8, 2022
@mx-psi

This comment was marked as outdated.

@mx-psi mx-psi marked this pull request as ready for review April 8, 2022 13:30
@mx-psi mx-psi requested review from a team as code owners April 8, 2022 13:30
@mx-psi mx-psi merged commit c186fc8 into main Apr 19, 2022
@mx-psi mx-psi deleted the mx-psi/remove-skips branch April 19, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card [deprecated] team/agent-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants