Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tcp queue length collector test on recent kernels #11180

Merged
merged 3 commits into from
Mar 8, 2022

Conversation

paulcacheux
Copy link
Contributor

@paulcacheux paulcacheux commented Mar 7, 2022

What does this PR do?

This PR fixes the tcp queue length collector test. On recent kernels, the default cgroup name is not "" anymore but user.slice or systemd.slice etc. To fix this issue, we compute the global max from all cgroups.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the config template has been updated.
Not Found
@paulcacheux paulcacheux added this to the 7.36.0 milestone Mar 7, 2022
@paulcacheux paulcacheux force-pushed the paulcacheux/tcp-queue-length-investigation branch from f80c254 to 3551c9a Compare March 8, 2022 10:45
@paulcacheux paulcacheux marked this pull request as ready for review March 8, 2022 10:51
@paulcacheux paulcacheux requested review from a team as code owners March 8, 2022 10:51
@paulcacheux paulcacheux changed the title Investigation around tcp queue length on recent kernels Fix tcp queue length collector test on recent kernels Mar 8, 2022
@paulcacheux paulcacheux requested a review from brycekahle March 8, 2022 15:48
@paulcacheux paulcacheux force-pushed the paulcacheux/tcp-queue-length-investigation branch from 2fbf6ef to e3399d5 Compare March 8, 2022 16:49
@paulcacheux paulcacheux merged commit 538df94 into main Mar 8, 2022
@paulcacheux paulcacheux deleted the paulcacheux/tcp-queue-length-investigation branch March 8, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants