Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] fix some glob pattern matching issue and add more test #10980

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

safchain
Copy link
Contributor

What does this PR do?

Fixes some mismatches in glob pattern matching and add corresponding tests

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • The appropriate team/.. label has been applied, if known.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the config template has been updated.

@safchain safchain force-pushed the safchain/fix-glob-matching branch from 22020b8 to 5eab6fa Compare February 17, 2022 13:39
@paulcacheux paulcacheux merged commit 260751b into main Feb 18, 2022
@paulcacheux paulcacheux deleted the safchain/fix-glob-matching branch February 18, 2022 11:11
Copy link
Contributor

@Gui774ume Gui774ume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(No QA for me thanks: this is a test 😄)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants