Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirements.txt contents and point to datadog-agent-buildimages #10732

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Feb 1, 2022

What does this PR do?

Replace current requirements.txt file with the latest version of the datadog-agent-buildimages requirements.txt file.

Motivation

We want to install dependencies on the images at build time to reduce the amount of network errors, while still keeping existing contributing instructions simple.

Additional Notes

This should be a no-op.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • The appropriate team/.. label has been applied, if known.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the config template has been updated.

@mx-psi mx-psi added this to the 7.35.0 milestone Feb 1, 2022
@mx-psi mx-psi added changelog/no-changelog dev/tooling [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card [deprecated] team/agent-platform labels Feb 1, 2022
@mx-psi mx-psi marked this pull request as ready for review February 1, 2022 10:28
@mx-psi mx-psi requested a review from a team as a code owner February 1, 2022 10:28
@mx-psi mx-psi merged commit 4463b1f into main Feb 1, 2022
@mx-psi mx-psi deleted the mx-psi/requirements-from-buildimages branch February 1, 2022 11:58
@paulcacheux
Copy link
Contributor

paulcacheux commented Feb 1, 2022

Hello ! Is this really a no-op ? For example a new developper running pip install -r requirements.txt at the root of the repo will get an error. This is a required step for a new environment since it installs invoke

@mx-psi
Copy link
Member Author

mx-psi commented Feb 1, 2022

For example a new developper running pip install -r requirements.txt at the root of the repo will get an error

No, a new developer should not see any changes. We keep the requirements.txt file, but make it so if you do pip install -r requirements.txt you are actually installing the requirements from datadog-agent-buildimages.

@mx-psi mx-psi changed the title Remove requirements.txt and point to datadog-agent-buildimages Remove requirements.txt contents and point to datadog-agent-buildimages Feb 1, 2022
@paulcacheux
Copy link
Contributor

Oh you are right ! I completely misunderstood the -r feature, sorry about that

@mx-psi
Copy link
Member Author

mx-psi commented Feb 1, 2022

No worries, it was a valid concern :)

albertvaka added a commit that referenced this pull request Feb 2, 2022
It doesn't seem to like the indirection we added in #10732
@albertvaka albertvaka mentioned this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants