Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace AppVeyor with Github Actions #10439

Merged
merged 4 commits into from
Jan 6, 2022
Merged

Replace AppVeyor with Github Actions #10439

merged 4 commits into from
Jan 6, 2022

Conversation

albertvaka
Copy link
Contributor

@albertvaka albertvaka commented Jan 6, 2022 •
edited
Loading

What does this PR do?

Move Windows unit tests from AppVeyor to Github Actions.

Motivation

AppVeyor has caused problems recently, and this way we have one CI less.

Possible Drawbacks / Trade-offs

  • Test time went up from ~35 min to ~45 min.
  • The number of concurrent jobs on Github Actions is 180 per account. We could reach that at some point the more things we run in Actions.

@albertvaka albertvaka added changelog/no-changelog [deprecated] team/agent-platform [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card labels Jan 6, 2022
@albertvaka albertvaka added this to the 7.34.0 milestone Jan 6, 2022
@albertvaka albertvaka requested a review from a team as a code owner January 6, 2022 01:05
@albertvaka albertvaka force-pushed the albertvaka/github-actions branch from c257235 to 386e36f Compare January 6, 2022 10:30
@albertvaka albertvaka force-pushed the albertvaka/github-actions branch from 8df412a to 2acf802 Compare January 6, 2022 12:37
julien-lebot
julien-lebot approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@julien-lebot julien-lebot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is the same pattern in Set up runner as well if you want to address that otherwise LGTM.

@albertvaka albertvaka merged commit 536be13 into main Jan 6, 2022
@albertvaka albertvaka deleted the albertvaka/github-actions branch January 6, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-lebot julien-lebot julien-lebot approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card [deprecated] team/agent-platform
Projects
None yet
Milestone
7.34.0
Development

Successfully merging this pull request may close these issues.
2 participants
@albertvaka @julien-lebot