fix(admission server): improve config methods naming

Signed-off-by: Wassim DHIF <wassim.dhif@datadoghq.com>
DataDog · Sep 4, 2024 · baf7a28 · baf7a28
1 parent b7aeb92
commit baf7a28
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pkg/clusteragent/admission/controllers/webhook/config.go b/pkg/clusteragent/admission/controllers/webhook/config.go
@@ -54,8 +54,8 @@ func NewConfig(admissionV1Enabled, namespaceSelectorEnabled bool) Config {
 
 func (w *Config) getWebhookName() string        { return w.webhookName }
 func (w *Config) getSecretName() string         { return w.secretName }
-func (w *Config) getValidationEnabled() bool    { return w.validationEnabled }
-func (w *Config) getMutationEnabled() bool      { return w.mutationEnabled }
+func (w *Config) isValidationEnabled() bool     { return w.validationEnabled }
+func (w *Config) isMutationEnabled() bool       { return w.mutationEnabled }
 func (w *Config) getSecretNs() string           { return w.namespace }
 func (w *Config) useAdmissionV1() bool          { return w.admissionV1Enabled }
 func (w *Config) useNamespaceSelector() bool    { return w.namespaceSelectorEnabled }

diff --git a/pkg/clusteragent/admission/controllers/webhook/controller_base.go b/pkg/clusteragent/admission/controllers/webhook/controller_base.go
@@ -98,14 +98,14 @@ func (c *controllerBase) generateWebhooks(wmeta workloadmeta.Component, pa workl
 	var mutatingWebhooks []Webhook
 
 	// Add Validating webhooks.
-	if c.config.getValidationEnabled() {
+	if c.config.isValidationEnabled() {
 		// Future validating webhooks can be added here.
 		validatingWebhooks = []Webhook{}
 		webhooks = append(webhooks, validatingWebhooks...)
 	}
 
 	// Add Mutating webhooks.
-	if c.config.getMutationEnabled() {
+	if c.config.isMutationEnabled() {
 		mutatingWebhooks = []Webhook{
 			configWebhook.NewWebhook(wmeta, injectionFilter),
 			tagsfromlabels.NewWebhook(wmeta, injectionFilter),