upgrade to go1.17.6 (#10689)

* upgrade to go1.17.6 in circleci and windows GH actions * changelog * Use new snyk image with Go1.17 Image is from the build job from https://github.com/DataDog/images/pull/2632 * update builders/buildimages refs * add go1.17 build flags to new files, including generated files ``` git ls-files | grep '\.go$' | xargs gofmt -w ``` * update docs and go.mod's * run 'inv tidy-all' in -compat=1.17 mode * add more -compat=1.17 * update to buildimages v6844966-47298a5 * codeql go version
DataDog · Feb 3, 2022 · 4d3948b · 4d3948b
1 parent 7636156
commit 4d3948b
Show file tree

Hide file tree

Showing 48 changed files with 485 additions and 276 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -15,7 +15,7 @@ experimental:
 templates:
   job_template: &job_template
     docker:
-      - image: datadog/datadog-agent-runner-circle:go11612
+      - image: datadog/datadog-agent-runner-circle:go1176
         environment:
           USE_SYSTEM_LIBS: "1"
     working_directory: /go/src/github.com/DataDog/datadog-agent

diff --git a/.circleci/images/runner/Dockerfile b/.circleci/images/runner/Dockerfile
@@ -29,7 +29,7 @@ RUN set -ex \
         ssh
 
 # Golang
-ENV GIMME_GO_VERSION 1.16.12
+ENV GIMME_GO_VERSION 1.17.6
 ENV GOROOT /root/.gimme/versions/go$GIMME_GO_VERSION.linux.amd64
 ENV GOPATH /go
 ENV PATH $GOROOT/bin:$GOPATH/bin:$PATH

diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
@@ -39,7 +39,7 @@ jobs:
 
       - uses: actions/setup-go@v2
         with:
-          go-version: 1.16.12
+          go-version: 1.17.6
 
       - name: Initialize CodeQL
         uses: github/codeql-action/init@v1

diff --git a/.github/workflows/windows-unittests.yml b/.github/workflows/windows-unittests.yml
@@ -24,7 +24,7 @@ jobs:
       - name: Install go
         uses: actions/setup-go@v2
         with:
-          go-version: '1.16.12'
+          go-version: '1.17.6'
 
       - name: Set up runner
         run: |

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
@@ -131,12 +131,12 @@ variables:
   S3_DSD6_URI: s3://dsd6-staging
   RELEASE_VERSION_6: nightly
   RELEASE_VERSION_7: nightly-a7
-  DATADOG_AGENT_BUILDIMAGES: v6554889-f294eac
-  DATADOG_AGENT_BUILDERS: v6554890-8eae026
-  DATADOG_AGENT_WINBUILDIMAGES: v6763937-323fb78
-  DATADOG_AGENT_ARMBUILDIMAGES: v6554889-f294eac
-  DATADOG_AGENT_SYSPROBE_BUILDIMAGES: v6696733-b6f229b
-  DATADOG_AGENT_NIKOS_BUILDIMAGES: v6554889-f294eac
+  DATADOG_AGENT_BUILDIMAGES: v6844966-47298a5
+  DATADOG_AGENT_BUILDERS: v6814105-5ec7b27
+  DATADOG_AGENT_WINBUILDIMAGES: v6844966-47298a5
+  DATADOG_AGENT_ARMBUILDIMAGES: v6844966-47298a5
+  DATADOG_AGENT_SYSPROBE_BUILDIMAGES: v6844966-47298a5
+  DATADOG_AGENT_NIKOS_BUILDIMAGES: v6844966-47298a5
   DATADOG_AGENT_EMBEDDED_PATH: /opt/datadog-agent/embedded
   NIKOS_INSTALL_DIR: /opt/datadog-agent/embedded/nikos
   NIKOS_EMBEDDED_PATH: /opt/datadog-agent/embedded/nikos/embedded

diff --git a/.gitlab/source_test/security_scan.yml b/.gitlab/source_test/security_scan.yml
@@ -4,7 +4,7 @@ security_scan_test:
   rules:
     !reference [.on_main_or_release_branch]
   stage: source_test
-  image: 486234852809.dkr.ecr.us-east-1.amazonaws.com/snyk:v5817527-cb0e69f-next
+  image: 486234852809.dkr.ecr.us-east-1.amazonaws.com/snyk:v6779027-23d6b05-next
   tags: ["runner:main"]
   needs: ["go_deps"]
   before_script:

diff --git a/README.md b/README.md
@@ -19,7 +19,7 @@ and development, is located under [the docs directory](docs) of the present repo
 ## Getting started
 
 To build the Agent you need:
- * [Go](https://golang.org/doc/install) 1.16 or later. You'll also need to set your `$GOPATH` and have `$GOPATH/bin` in your path.
+ * [Go](https://golang.org/doc/install) 1.17 or later. You'll also need to set your `$GOPATH` and have `$GOPATH/bin` in your path.
  * Python 3.7+ along with development libraries for tooling. You will also need Python 2.7 if you are building the Agent with Python 2 support.
  * Python dependencies. You may install these with `pip install -r requirements.txt`
    This will also pull in [Invoke](http://www.pyinvoke.org) if not yet installed.

diff --git a/cmd/system-probe/utils/memory_monitor_linux.go b/cmd/system-probe/utils/memory_monitor_linux.go
@@ -3,6 +3,7 @@
 // This product includes software developed at Datadog (https://www.datadoghq.com/).
 // Copyright 2016-present Datadog, Inc.
 
+//go:build linux
 // +build linux
 
 package utils

diff --git a/cmd/system-probe/utils/memory_monitor_stub.go b/cmd/system-probe/utils/memory_monitor_stub.go
@@ -3,6 +3,7 @@
 // This product includes software developed at Datadog (https://www.datadoghq.com/).
 // Copyright 2016-present Datadog, Inc.
 
+//go:build !linux
 // +build !linux
 
 package utils

diff --git a/devenv/scripts/Install-DevEnv.ps1 b/devenv/scripts/Install-DevEnv.ps1
@@ -45,11 +45,11 @@ Write-Host -ForegroundColor Yellow -BackgroundColor DarkGreen '- Installing Gola
 $ErrorActionPreference = 'Stop'
 $ProgressPreference = 'SilentlyContinue'
 
-Write-Host -ForegroundColor Green "Installing go 1.16.12"
+Write-Host -ForegroundColor Green "Installing go 1.17.6"
 
-$gozip = "https://dl.google.com/go/go1.16.12.windows-amd64.zip"
+$gozip = "https://dl.google.com/go/go1.17.6.windows-amd64.zip"
 if ($Env:TARGET_ARCH -eq "x86") {
-    $gozip = "https://dl.google.com/go/go1.16.12.windows-386.zip"
+    $gozip = "https://dl.google.com/go/go1.17.6.windows-386.zip"
 }
 
 $out = 'c:\go.zip'

diff --git a/docs/dev/agent_dev_env.md b/docs/dev/agent_dev_env.md
@@ -93,7 +93,7 @@ variables (see Invoke docs for more details).
 
 ## Golang
 
-You must [install Golang](https://golang.org/doc/install) version `1.16.12` or
+You must [install Golang](https://golang.org/doc/install) version `1.17.6` or
 higher. Make sure that `$GOPATH/bin` is in your `$PATH` otherwise `invoke`
 cannot use any additional tool it might need.