[omnibus] Target MacOS 10.12 when building on MacOS (#5067)

Sets MACOSX_DEPLOYMENT_TARGET to 10.12 for the whole omnibus build to make sure we only use symbols available on 10.12.
DataDog · Mar 5, 2020 · 28451a9 · 28451a9
1 parent d294af3
commit 28451a9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/omnibus/config/software/python2.rb b/omnibus/config/software/python2.rb
@@ -48,8 +48,7 @@
                           "--with-universal-archs=intel",
                           "--enable-shared",
                           "--without-gcc",
-                          "CC=clang",
-                          "MACOSX_DEPLOYMENT_TARGET=10.12")
+                          "CC=clang")
   elsif linux?
     python_configure.push("--enable-unicode=ucs4",
                           "--enable-shared")

diff --git a/tasks/agent.py b/tasks/agent.py
@@ -412,6 +412,10 @@ def omnibus_build(ctx, puppy=False, agent_binaries=False, log_level="info", base
                 env['SIGN_PFX'] = "{}".format(pfxfile)
                 env['SIGN_PFX_PW'] = "{}".format(pfxpass)
 
+            if sys.platform == 'darwin':
+                # Target MacOS 10.12
+                env['MACOSX_DEPLOYMENT_TARGET'] = '10.12'
+
             if omnibus_s3_cache:
                 args['populate_s3_cache'] = " --populate-s3-cache "
             if skip_sign: