[ACIX-1061] Create BuildMetadata class for keeping track of build artifact's metadata
#185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ishirui
force-pushed
the
pierrelouis.veyrenc/ACIX-1035-git-related-commands-classes
branch
3 times, most recently
from
6456bbc to
5d62a2e
Compare
Ishirui
force-pushed
the
pierrelouis.veyrenc/ACIX-1035-build-infra
branch
from
1422caf to
18538c1
Compare
Ishirui
force-pushed
the
pierrelouis.veyrenc/ACIX-1035-git-related-commands-classes
branch
from
5d62a2e to
73a49be
Compare
Ishirui
force-pushed
the
pierrelouis.veyrenc/ACIX-1035-build-infra
branch
3 times, most recently
from
f13089c to
bb0d5ba
Compare
Ishirui
changed the title
BuildMetadata class for keeping track of build artifact's metadataBuildMetadata class for keeping track of build artifact's metadata
Ishirui
force-pushed
the
pierrelouis.veyrenc/ACIX-1035-build-infra
branch
from
6f62ef3 to
33e0775
Compare
Ishirui
force-pushed
the
pierrelouis.veyrenc/ACIX-1035-git-related-commands-classes
branch
from
528e48d to
2100703
Compare
Base automatically changed from
pierrelouis.veyrenc/ACIX-1035-git-related-commands-classes
to
main
September 26, 2025 08:44
Ishirui
force-pushed
the
pierrelouis.veyrenc/ACIX-1035-build-infra
branch
4 times, most recently
from
403ba8a to
9b7c2cc
Compare
The metadata schema is based on the "Build UX" section of the "Future of Agent development" document from @ofek These `BuildMetadata` objects are meant to be serialized to a file and dropped along with the build artifact. Therefore it is important to make sure that they are frozen and can be nicely serialized to a file.
Ishirui
force-pushed
the
pierrelouis.veyrenc/ACIX-1035-build-infra
branch
from
9b7c2cc to
1075e38
Compare
…DOCKER` to `ArtifactFormat.OCI`
…ilename` This makes the "mostly static" part of the filename as long as possible (ordering fields by how likely they are to change)
Ishirui
force-pushed
the
pierrelouis.veyrenc/ACIX-1035-build-infra
branch
from
2cdc866 to
67227fa
Compare
This is necessary in particular for container images, for which taking the sha256sum does not mean anything.
…nums.py` to `platforms.py`
This allows for easier overriding of anything that is inferred context + makes it easier to test, which is always a good sign !
Ishirui
force-pushed
the
pierrelouis.veyrenc/ACIX-1035-build-infra
branch
2 times, most recently
from
1582f9c to
39ae83b
Compare
- Avoid using checked-in fixtures for `Path.hexdigest` tests
git automatically converts Unix-style line endings to Windows-style endings when checking out on a Windows platform. This changes the hash of text-mode binary files we use for testing `Path.hexdigest`.
To avoid this, we simply write some data on-the fly during the test instead of relying on checked-in fixtures.
- Close file handle in `temp_file` context manager
`NamedTemporaryFile` actually opens the created file automatically. To be consistent with `temp_directory` and the rest of the Path class, we return a Path instead. This means we now have an inaccessible open file handle. Callers then usually re-open the file manually using the path, creating a second open file handle.
This is not a problem on UNIX systems, as the same file can have multiple open handles from the same process - this is not the case on Windows however: https://docs.python.org/3.9/library/tempfile.html#tempfile.NamedTemporaryFile
- Avoid some permissions issues
Ishirui
force-pushed
the
pierrelouis.veyrenc/ACIX-1035-build-infra
branch
from
39ae83b to
1ac971d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.