Add a dda command to automatically sync cursor rules in other coding agent files #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinFairise2
force-pushed
the
kfairise/dda-ai-rules-sync
branch
6 times, most recently
from
746b659 to
406707b
Compare
CelianR
reviewed
Aug 29, 2025
Ishirui
reviewed
Aug 29, 2025
There was a problem hiding this comment.
Thanks a lot for this ! Please ask for re-review once you've had another look :)
For the naming convention, I think ai is fine, but only if we choose to also merge all mcp commands under here (so we'd have dda ai mcp ...). @ofek what do you think ?
tests/cli/ai/rules/test_sync.py
Outdated
Comment on lines
17
to
56
| @pytest.fixture(name="create_temp_file_or_dir") | ||
| def fixt_create_temp_file_or_dir(): | ||
| """Fixture to create and clean up temporary files and directories.""" | ||
| created_paths: list[Path] = [] | ||
|
|
||
| def _create_temp_file_or_dir(location: Path, *, force_file: bool = False) -> None: | ||
| for parent in reversed(location.parents): | ||
| # Create and keep track of created parent directories for cleanup | ||
| if not parent.exists(): | ||
| parent.mkdir() | ||
| created_paths.append(parent) | ||
|
|
||
| # Create the requested file or directory and keep track of it for cleanup | ||
| # Assume that if the file path does not have an extension, it is a directory | ||
| # The force_file flag can be used to override this behavior | ||
| if location.suffix == "" and not force_file: | ||
| location.mkdir() | ||
| else: | ||
| location.touch() | ||
| created_paths.append(location) | ||
|
|
||
| yield _create_temp_file_or_dir | ||
| for path in reversed(created_paths): | ||
| if path.exists(): | ||
| if path.is_dir(): | ||
| path.rmdir() | ||
| else: | ||
| path.unlink() | ||
|
|
||
|
|
||
| @pytest.fixture(name="create_cursor_rules") | ||
| def fixt_create_cursor_rules(create_temp_file_or_dir): | ||
| def _create_cursor_rules(rules_data: dict[str, str], cursor_rules_dir: Path) -> None: | ||
| """Create cursor rule files with given content.""" | ||
| for filename, content in rules_data.items(): | ||
| rule_file = cursor_rules_dir / filename | ||
| create_temp_file_or_dir(rule_file, force_file=True) | ||
| rule_file.write_text(content, encoding="utf-8") | ||
|
|
||
| return _create_cursor_rules |
There was a problem hiding this comment.
I think this is very similar to what I implemented in tests/cli/info/owners/test_code.py. Since the same code is now reused in multiple places, could we consider making these fixtures generic and sharing them by putting them in conftest.py ?
tests/cli/ai/rules/test_sync.py
Outdated
| return _create_cursor_rules | ||
|
|
||
|
|
||
| def test_sync_basic_functionality( |
There was a problem hiding this comment.
I think we can merge a few of these and use pytest.mark.parametrize. What do you think ?
CelianR
approved these changes
Oct 10, 2025
| f.write(new_content) | ||
| app.display_success(f"Successfully fixed {target_file}") | ||
| else: | ||
| unsynced_targets.append(str(target_file)) |
There was a problem hiding this comment.
Suggested change
| unsynced_targets.append(str(target_file)) | |
| unsynced_targets.append(str(target_file)) |
tests/cli/validate/__init__.py
Outdated
| @@ -0,0 +1,3 @@ | |||
| # SPDX-FileCopyrightText: 2025-present Datadog, Inc. <dev@datadoghq.com> | |||
| # | |||
| # SPDX-License-Identifier: MIT No newline at end of file | |||
There was a problem hiding this comment.
NIT: Could you add a line feed here?
tests/cli/validate/test_ai-rules.py
Outdated
Comment on lines
161
to
162
|
|
||
|
|
Fix tests + use fixture folder instead
KevinFairise2
force-pushed
the
kfairise/dda-ai-rules-sync
branch
3 times, most recently
from
b3bb9f5 to
c02c318
Compare
KevinFairise2
force-pushed
the
kfairise/dda-ai-rules-sync
branch
from
c02c318 to
4e2c733
Compare
KevinFairise2
force-pushed
the
kfairise/dda-ai-rules-sync
branch
from
7d9cb8b to
2254a55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new
dda validatetree used for AI and Coding agent related utilities.Implement
dda validate ai-rulescommand to automatically synchronize Cursor rules to other coding agent files.Default usage will pick all the rules in
.cursor/rulesand add them in CLAUDE.md file, so that claude can use the rules defined for Cursor.Also adds a
--fixflag to be used locally to sync the rules