Add Bazel tooling #161
Merged
Add Bazel tooling #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CelianR
approved these changes
Aug 4, 2025
Ishirui
approved these changes
Aug 4, 2025
Comment on lines
+1
to
+24
| # SPDX-FileCopyrightText: 2025-present Datadog, Inc. <dev@datadoghq.com> | ||
| # | ||
| # SPDX-License-Identifier: MIT | ||
| from __future__ import annotations | ||
|
|
||
| from typing import TYPE_CHECKING | ||
|
|
||
| import click | ||
|
|
||
| from dda.cli.base import dynamic_command, pass_app | ||
|
|
||
| if TYPE_CHECKING: | ||
| from dda.cli.application import Application | ||
|
|
||
|
|
||
| @dynamic_command( | ||
| short_help="Run Bazel commands", | ||
| context_settings={"help_option_names": [], "ignore_unknown_options": True}, | ||
| ) | ||
| @click.argument("args", nargs=-1) | ||
| @pass_app | ||
| def cmd(app: Application, *, args: tuple[str, ...]) -> None: | ||
| process = app.tools.bazel.attach(list(args), check=False) | ||
| app.abort(code=process.returncode) |
There was a problem hiding this comment.
Just a thought for the future: do we want these kind of direct "tool-invocation" sort of commands to live in the build namespace ? It might be best to reserve that for the actual build tasks that we'll implement in the future, like dda build agent, dda build dogstatsd etc.
Maybe run or launch or exec or something similar would work ? We are after all just delegating the execution of some command to another tool
There was a problem hiding this comment.
- I think
bazelwould be the only exception for thebuildcommand group, it makes most sense for it to be there. The number of sister command groups would be smaller and more nested e.g.build compfor building individual components like the core Agent binary,build distfor building distributions like an MSI installer or a container, etc. The command could be instead something liketools bazel runbut then it wouldn't be as intuitive or discoverable. - A nice part about having the command right under
buildis that it removes the need to have an extra word (run, exec, etc.) and you can just pass arguments directly tobazel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a way to run Bazel commands and use a managed installation if there are no Bazel executables on PATH (or if configured as such).