refactor(git): Replace __new__ override with explicit constructor

Author: Ishirui

src/dda/tools/git.py

@@ -85,7 +85,7 @@ def get_remote_details(self, remote_name: str = "origin") -> Remote:
             ["config", "--get", f"remote.{remote_name}.url"],
         ).strip()
 
-        return Remote(remote_url)  # type: ignore[abstract]
+        return Remote.from_url(remote_url)  # type: ignore[abstract]
 
     def get_head_commit(self) -> Commit:
         """

src/dda/utils/git/remote.py

@@ -17,16 +17,14 @@
 class Remote(ABC):
     protocol: ClassVar[Literal["https", "git"]]
 
-    def __new__(cls, url: str) -> Remote:  # noqa: PYI034
-        if cls is Remote:
-            if url.startswith("https://"):
-                return HTTPSRemote(url)
-            if url.startswith("git@"):
-                return SSHRemote(url)
-            msg = f"Invalid protocol: {url}"
-            raise ValueError(msg)
-
-        return super().__new__(cls)
+    @classmethod
+    def from_url(cls, url: str) -> Remote:
+        if url.startswith("https://"):
+            return HTTPSRemote(url)
+        if url.startswith("git@"):
+            return SSHRemote(url)
+        msg = f"Invalid protocol: {url}"
+        raise ValueError(msg)
 
     def __init__(self, url: str) -> None:
         self.url = url

tests/utils/git/test_commit.py

@@ -97,7 +97,7 @@ def test_details_github_git_equality(self, app, mocker):
             "dda.utils.network.http.client.HTTPClient.get",
             return_value=Response(status_code=200, content=github_payload_str),
         )
-        github_details = commit.get_details_from_remote(Remote("https://github.com/foo/bar"))
+        github_details = commit.get_details_from_remote(Remote.from_url("https://github.com/foo/bar"))
 
         # Mock Git.capture to return payload from file
         git_output_file = Path(__file__).parent / "fixtures" / "git_show_dda_1425a34.txt"

tests/utils/git/test_github.py

@@ -7,24 +7,24 @@
 
 
 def test_get_github_url():
-    remote = Remote(url="https://github.com/foo/bar")
+    remote = Remote.from_url(url="https://github.com/foo/bar")
     assert get_github_url(remote) == "https://github.com/foo/bar"
 
 
 def test_get_github_api_url():
-    remote = Remote(url="https://github.com/foo/bar")
+    remote = Remote.from_url(url="https://github.com/foo/bar")
     assert get_github_api_url(remote) == "https://api.github.com/repos/foo/bar"
 
 
 def test_get_commit_github_url():
-    remote = Remote(url="https://github.com/foo/bar")
+    remote = Remote.from_url(url="https://github.com/foo/bar")
     sha1 = "1234567890" * 4
     commit = Commit(sha1=sha1)
     assert get_commit_github_url(remote, commit) == f"https://github.com/foo/bar/commit/{sha1}"
 
 
 def test_get_commit_github_api_url():
-    remote = Remote(url="https://github.com/foo/bar")
+    remote = Remote.from_url(url="https://github.com/foo/bar")
     sha1 = "1234567890" * 4
     commit = Commit(sha1=sha1)
     assert get_commit_github_api_url(remote, commit) == f"https://api.github.com/repos/foo/bar/commits/{sha1}"

tests/utils/git/test_remote.py

@@ -30,7 +30,7 @@ class TestRemoteClass:
         ],
     )
     def test_basic(self, url):
-        remote = Remote(url=url)
+        remote = Remote.from_url(url=url)
         assert remote.url == url
         assert remote.org == "foo"
         assert remote.repo == "bar"
@@ -59,7 +59,7 @@ def test_get_commit_details_and_changes_from_remote(self, mocker, github_payload
         github_payload = json.loads(github_payload_str)
         sha1 = github_payload["sha"]
         commit_url = github_payload["commit"]["url"]
-        remote = Remote(url=commit_url)
+        remote = Remote.from_url(url=commit_url)
         commit = Commit(sha1=sha1)
 
         # Create a CommitDetails object