refactor(git): Move everything related to GitHub to own file

Author: Ishirui

src/dda/utils/git/github.py

@@ -0,0 +1,26 @@
+# SPDX-FileCopyrightText: 2025-present Datadog, Inc. <dev@datadoghq.com>
+#
+# SPDX-License-Identifier: MIT
+from __future__ import annotations
+
+from typing import TYPE_CHECKING
+
+if TYPE_CHECKING:
+    from dda.utils.git.commit import Commit
+    from dda.utils.git.remote import Remote
+
+
+def get_github_url(remote: Remote) -> str:
+    return f"https://github.com/{remote.full_repo}"
+
+
+def get_github_api_url(remote: Remote) -> str:
+    return f"https://api.github.com/repos/{remote.full_repo}"
+
+
+def get_commit_github_url(remote: Remote, commit: Commit) -> str:
+    return f"{get_github_url(remote)}/commit/{commit.sha1}"
+
+
+def get_commit_github_api_url(remote: Remote, commit: Commit) -> str:
+    return f"{get_github_api_url(remote)}/commits/{commit.sha1}"

src/dda/utils/git/remote.py

@@ -49,32 +49,19 @@ def repo(self) -> str:
     def full_repo(self) -> str:
         return f"{self.org}/{self.repo}"
 
-    @cached_property
-    def github_url(self) -> str:
-        return f"https://github.com/{self.full_repo}"
-
-    @cached_property
-    def github_api_url(self) -> str:
-        return f"https://api.github.com/repos/{self.full_repo}"
-
-    def get_commit_github_url(self, commit: Commit) -> str:
-        return f"{self.github_url}/commit/{commit.sha1}"
-
-    def get_commit_github_api_url(self, commit: Commit) -> str:
-        return f"{self.github_api_url}/commits/{commit.sha1}"
-
     def get_details_and_changes_for_commit(self, commit: Commit) -> tuple[CommitDetails, ChangeSet]:
         """
         Get the details and set of changes for a given commit by querying the remote.
         """
         from datetime import datetime
 
         from dda.utils.fs import Path
-        from dda.utils.git.changeset import ChangeSet, ChangedFile
+        from dda.utils.git.changeset import ChangedFile, ChangeSet
+        from dda.utils.git.github import get_commit_github_api_url
         from dda.utils.network.http.client import get_http_client
 
         client = get_http_client()
-        data = client.get(self.get_commit_github_api_url(commit)).json()
+        data = client.get(get_commit_github_api_url(self, commit)).json()
 
         # Compute ChangeSet
         changes = ChangeSet.from_iter(

tests/utils/git/test_github.py

@@ -0,0 +1,30 @@
+# SPDX-FileCopyrightText: 2025-present Datadog, Inc. <dev@datadoghq.com>
+#
+# SPDX-License-Identifier: MIT
+from dda.utils.git.commit import Commit
+from dda.utils.git.github import get_commit_github_api_url, get_commit_github_url, get_github_api_url, get_github_url
+from dda.utils.git.remote import Remote
+
+
+def test_get_github_url():
+    remote = Remote(url="https://github.com/foo/bar")
+    assert get_github_url(remote) == "https://github.com/foo/bar"
+
+
+def test_get_github_api_url():
+    remote = Remote(url="https://github.com/foo/bar")
+    assert get_github_api_url(remote) == "https://api.github.com/repos/foo/bar"
+
+
+def test_get_commit_github_url():
+    remote = Remote(url="https://github.com/foo/bar")
+    sha1 = "1234567890" * 4
+    commit = Commit(sha1=sha1)
+    assert get_commit_github_url(remote, commit) == f"https://github.com/foo/bar/commit/{sha1}"
+
+
+def test_get_commit_github_api_url():
+    remote = Remote(url="https://github.com/foo/bar")
+    sha1 = "1234567890" * 4
+    commit = Commit(sha1=sha1)
+    assert get_commit_github_api_url(remote, commit) == f"https://api.github.com/repos/foo/bar/commits/{sha1}"

tests/utils/git/test_remote.py

@@ -10,7 +10,7 @@
 from httpx import Response
 
 from dda.utils.fs import Path
-from dda.utils.git.changeset import ChangeSet, ChangedFile
+from dda.utils.git.changeset import ChangedFile, ChangeSet
 from dda.utils.git.commit import Commit, CommitDetails
 from dda.utils.git.remote import HTTPSRemote, Remote, SSHRemote, get_change_type_from_github_status
 
@@ -35,27 +35,13 @@ def test_basic(self, url):
         assert remote.org == "foo"
         assert remote.repo == "bar"
         assert remote.full_repo == "foo/bar"
-        assert remote.github_url == "https://github.com/foo/bar"
-        assert remote.github_api_url == "https://api.github.com/repos/foo/bar"
         if url.startswith("https://"):
             assert isinstance(remote, HTTPSRemote)
             assert remote.protocol == "https"
         elif url.startswith("git@"):
             assert isinstance(remote, SSHRemote)
             assert remote.protocol == "git"
 
-    def test_get_commit_github_url(self):
-        remote = Remote(url="https://github.com/foo/bar")
-        sha1 = "1234567890" * 4
-        commit = Commit(sha1=sha1)
-        assert remote.get_commit_github_url(commit) == f"https://github.com/foo/bar/commit/{sha1}"
-
-    def test_get_commit_github_api_url(self):
-        remote = Remote(url="https://github.com/foo/bar")
-        sha1 = "1234567890" * 4
-        commit = Commit(sha1=sha1)
-        assert remote.get_commit_github_api_url(commit) == f"https://api.github.com/repos/foo/bar/commits/{sha1}"
-
     @pytest.mark.parametrize(
         "github_payload_file",
         ["commit_example_dda_1425a34.json", "commit_example_multiple_parents.json"],