Remove source file and datadog-signing-keys package when removing the Agent #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 5, 2022 13:59
bkabrda
suggested changes
Dec 7, 2022
libraries/recipe_helpers.rb
Outdated
| @@ -7,6 +7,11 @@ class << self | |||
| datadog-iot-agent | |||
| ].freeze | |||
|
|
|||
| # This method stores a variable that is used across recipes so we needed a place to define it | |||
There was a problem hiding this comment.
Another potential place to store a variable like this might be https://github.com/DataDog/chef-datadog/blob/main/attributes/default.rb, but that would also mean users could change it, which we don't want, so I think it's ok to have it defined here. Perhaps you could expand this comment to note the reason why this is not in default.rb?
There was a problem hiding this comment.
Right, that'd be clearer ! Fixed in 399a428.
recipes/remove-dd-agent.rb
Outdated
|
|
||
| # Then remove the installation files (depending on the OS: sources_list file, datadog-signing-keys package...) | ||
| case node['platform_family'] | ||
| when 'amazon', 'rhel' # 'rhel' includes redhat, centos, rocky, scientific and almalinux |
There was a problem hiding this comment.
I think you're missing fedora here, this should match https://github.com/DataDog/chef-datadog/blob/main/recipes/repository.rb#L165
There was a problem hiding this comment.
Forgot to put it back, mb ! Fixed in 5c87ee8.
bkabrda
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #847 .
This PR also adds some tests to check that once deleting the Agent, the source file and the
datadog-signing-keyspackage are also removed from the host.