[RUM-13448] Add source code context injection for microfrontend #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amortemousque
force-pushed
the
aymeric/rum-microfrontend
branch
from
acd05a6 to
f38fce4
Compare
amortemousque
force-pushed
the
aymeric/rum-microfrontend
branch
from
f38fce4 to
761d68d
Compare
yoannmoinet
reviewed
Dec 18, 2025
Member
yoannmoinet
left a comment
yoannmoinet
left a comment
There was a problem hiding this comment.
Looks super good.
Thanks for tackling this.
Do you think you could also update ownership of the plugin?
build-plugins/.github/CODEOWNERS
Line 26 in ae68609
I mostly had small comments.
Member
There was a problem hiding this comment.
Is this file accidentally duplicated?
| return toReturn; | ||
| } | ||
|
|
||
| const cfg = validatedOptions.sourceCodeContext as SourceCodeContextOptions; |
Member
There was a problem hiding this comment.
Would this work?
I'm not a super fan of as casting.
Suggested change
| const cfg = validatedOptions.sourceCodeContext as SourceCodeContextOptions; | |
| const cfg: SourceCodeContextOptions = validatedOptions.sourceCodeContext; |
| const cfg = validatedOptions.sourceCodeContext as SourceCodeContextOptions; | ||
|
|
||
| if (!cfg?.service || typeof cfg.service !== 'string') { | ||
| toReturn.errors.push(`Missing ${red('"sourceCodeContext.service"')}.`); |
Member
There was a problem hiding this comment.
To avoid any confusion from user's standpoint.
Suggested change
| toReturn.errors.push(`Missing ${red('"sourceCodeContext.service"')}.`); | |
| toReturn.errors.push(`Missing ${red('"rum.sourceCodeContext.service"')}.`); |
Comment on lines
+45
to
+47
| { | ||
| entry: bundlers.reduce((acc, bundler) => ({ ...acc, [bundler]: './index.js' }), {}), | ||
| }, |
Member
There was a problem hiding this comment.
Is this necessary?
I think this is the default.
Suggested change
| { | |
| entry: bundlers.reduce((acc, bundler) => ({ ...acc, [bundler]: './index.js' }), {}), | |
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
This PR adds source code context injection capabilities to the RUM plugin, enabling customers to identify which microfrontend originates each RUM event in their applications. It focuses on setups with separated bundles loaded via dynamic imports (e.g., module federation) by injecting source code metadata at entry points.
How?