Skip to content

Conversation

@rgaignault
Copy link
Contributor

@rgaignault rgaignault commented Dec 17, 2025

Motivation

To match graphQL attribute generated by IOS sdk and also match rum-event-format, we should update the naming in the SDK.

Changes

Change errors_count to error_count. This could be a breaking change for dashboard/query please modify the field name in consequences.

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@rgaignault rgaignault requested a review from a team as a code owner December 17, 2025 15:37
@datadog-datadog-prod-us1
Copy link

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Overall Coverage: 92.67% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 931c474 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 17, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 164.34 KiB 164.34 KiB -1 B -0.00%
Rum Profiler 4.32 KiB 4.32 KiB 0 B 0.00%
Rum Recorder 20.03 KiB 20.03 KiB 0 B 0.00%
Logs 56.14 KiB 56.14 KiB 0 B 0.00%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 121.62 KiB 121.62 KiB -1 B -0.00%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.004 0.0067 +67.50%
RUM - add action 0.0161 0.014 -13.04%
RUM - add error 0.0148 0.017 +14.86%
RUM - add timing 0.0027 0.0032 +18.52%
RUM - start view 0.0032 0.0036 +12.50%
RUM - start/stop session replay recording 0.0008 0.0009 +12.50%
Logs - log message 0.0133 0.019 +42.86%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 25.54 KiB 24.95 KiB -598 B
RUM - add action 52.59 KiB 46.79 KiB -5.79 KiB
RUM - add timing 24.36 KiB 24.95 KiB +597 B
RUM - add error 55.00 KiB 50.99 KiB -4.01 KiB
RUM - start/stop session replay recording 23.56 KiB 23.78 KiB +217 B
RUM - start view 422.92 KiB 423.62 KiB +722 B
Logs - log message 44.35 KiB 44.68 KiB +344 B

🔗 RealWorld

@rgaignault rgaignault merged commit 090ab1f into main Dec 17, 2025
22 checks passed
@rgaignault rgaignault deleted the romanG/match-rum-event-format-attributes branch December 17, 2025 16:14
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants