add s/s action #4038

BeltranBulbarellaDD · 2025-12-17T15:34:38Z

Motivation

Discussed in this RFC

Tldr: addEvent does not cover all the cases needed for complete action collection in frameworks like Flutter.
This PR adds Start and Stop action.

Changes

Added telemetry event type to test locally (For CI to pass, need to add in RumEventsFormat PR)

Added FF: START_STOP_ACTION

Expanded ActionType

Created expanded startActionCollection, created startCustomActionInternal and stopCustomActionInternal

Test instructions

I used this HTML file to test locally.
Should be able to start an action, generate events and stop the action. When in RUM explorer Attributes for each Event should have the Action.ID.
Example action with error, long_task and resource.

Checklist

Tested locally
Tested on staging
Added unit tests for this change.
Added e2e/integration tests for this change.

cit-pr-commenter · 2025-12-17T15:36:52Z

Bundles Sizes Evolution

📦 Bundle Name	Base Size	Local Size	𝚫	𝚫%	Status
Rum	164.37 KiB	166.72 KiB	+2.35 KiB	+1.43%	✅
Rum Profiler	4.32 KiB	4.32 KiB	0 B	0.00%	✅
Rum Recorder	20.01 KiB	20.01 KiB	0 B	0.00%	✅
Logs	56.14 KiB	56.18 KiB	+40 B	+0.07%	✅
Flagging	944 B	944 B	0 B	0.00%	✅
Rum Slim	121.64 KiB	123.80 KiB	+2.16 KiB	+1.77%	✅
Worker	23.63 KiB	23.63 KiB	0 B	0.00%	✅

🚀 CPU Performance

Action Name	Base CPU Time (ms)	Local CPU Time (ms)	𝚫%
RUM - add global context	0.0055	0.004	-27.27%
RUM - add action	0.0144	0.0119	-17.36%
RUM - add error	0.0164	0.0114	-30.49%
RUM - add timing	0.0038	0.0026	-31.58%
RUM - start view	0.005	0.0032	-36.00%
RUM - start/stop session replay recording	0.0011	0.0007	-36.36%
Logs - log message	0.0173	0.0128	-26.01%

🧠 Memory Performance

Action Name	Base Memory Consumption	Local Memory Consumption	𝚫
RUM - add global context	25.06 KiB	24.91 KiB	-156 B
RUM - add action	47.68 KiB	47.82 KiB	+143 B
RUM - add timing	24.00 KiB	24.92 KiB	+947 B
RUM - add error	53.93 KiB	51.41 KiB	-2.52 KiB
RUM - start/stop session replay recording	23.65 KiB	24.94 KiB	+1.29 KiB
RUM - start view	422.25 KiB	423.20 KiB	+973 B
Logs - log message	44.46 KiB	44.74 KiB	+288 B

🔗 RealWorld

datadog-datadog-prod-us1 · 2025-12-17T15:48:06Z

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
• Patch Coverage: 86.15%
• Overall Coverage: 77.32% (+0.07%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 5b40d1e | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

BeltranBulbarellaDD · 2025-12-18T14:12:48Z

@codex

chatgpt-codex-connector · 2025-12-18T14:13:49Z

Thanks for the ping—current CI is all green and bundle size deltas are small (≈+0.8% on Rum/Rum Slim, others unchanged). Patch coverage on the new lines is ~85% with overall coverage unchanged aside from reported delta. Let me know if you want me to tackle any follow-ups.

View task →

BeltranBulbarellaDD · 2025-12-31T08:14:31Z

@codex pls review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

packages/rum-core/src/domain/action/actionCollection.ts

BeltranBulbarellaDD · 2026-01-02T15:02:03Z

@codex review pls

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

packages/rum-core/src/domain/action/actionCollection.ts

BeltranBulbarellaDD · 2026-01-05T13:05:00Z

@codex review pls

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e8725bad56

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

packages/rum-core/src/domain/action/actionCollection.ts

BeltranBulbarellaDD · 2026-01-05T13:31:37Z

packages/rum-core/src/domain/action/actionCollection.ts

  configuration: RumConfiguration
 ) {
+  const customActionHistory = createValueHistory<string>({ expireDelay: ACTION_CONTEXT_TIME_OUT_DELAY })
+  const activeCustomActions = new Map<string, ActiveCustomAction>()


I wonder if this should be a weakMap like in VitalCollection so it gets garbage collected

BeltranBulbarellaDD · 2026-01-05T13:32:54Z

@codex review pls

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9864c12b4a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

packages/rum-core/src/domain/action/actionCollection.ts

BeltranBulbarellaDD · 2026-01-05T14:33:06Z

@codex review pls

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a19c4d0ac7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

packages/rum-core/src/domain/action/actionCollection.ts

BeltranBulbarellaDD · 2026-01-06T09:44:08Z

@codex pls review

chatgpt-codex-connector · 2026-01-06T09:55:55Z

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

add s/s action

2f11566

BeltranBulbarellaDD added 4 commits December 17, 2025 16:24

Add unit tests for startAction and stopAction

065a6fe

Linting fixes

aec81c6

cleanup

270c0cb

fix leaked listener

b0bc642

BeltranBulbarellaDD added 7 commits December 30, 2025 13:23

Integrated trackEventCounts and integrate with startActionCollection.

a06410a

Merge branch 'main' into beltran.bulbarella/start-stopAction

2080477

merged rum-events-format

b4af4f6

Fix format

3e88bd7

sync schemas

f129855

fix comma

2259509

Add telemetry type (remove after merge in R-E-F)

446390e

chatgpt-codex-connector bot reviewed Dec 31, 2025

View reviewed changes

packages/rum-core/src/domain/action/actionCollection.ts Show resolved Hide resolved

BeltranBulbarellaDD added 4 commits December 31, 2025 10:12

Add loading_time to custom actions

efe5ffc

wait for fetch to complete in e2e test so to avoid flaky test

2c95977

revert test

546fdde

wait for requests to complete in e2e test so to avoid flaky test

d7a7e14

chatgpt-codex-connector bot reviewed Jan 2, 2026

View reviewed changes

packages/rum-core/src/domain/action/actionCollection.ts Outdated Show resolved Hide resolved

Update activeCustomActions to track existing actions

e8725ba

chatgpt-codex-connector bot reviewed Jan 5, 2026

View reviewed changes

packages/rum-core/src/domain/action/actionCollection.ts Show resolved Hide resolved

Clean up activeCustomActions on session renewal

9864c12

BeltranBulbarellaDD commented Jan 5, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Jan 5, 2026

View reviewed changes

packages/rum-core/src/domain/action/actionCollection.ts Show resolved Hide resolved

Stop active actions on session renewal, and reset the action context.

a19c4d0

chatgpt-codex-connector bot reviewed Jan 5, 2026

View reviewed changes

packages/rum-core/src/domain/action/actionCollection.ts Show resolved Hide resolved

Clean up active custom actions on stop()

5b40d1e

BeltranBulbarellaDD mentioned this pull request Jan 6, 2026

add start/stop action telemetry type DataDog/rum-events-format#335

Draft

add s/s action #4038

Are you sure you want to change the base?

add s/s action #4038

Conversation

BeltranBulbarellaDD commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Changes

Test instructions

Checklist

Uh oh!

cit-pr-commenter bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundles Sizes Evolution

Uh oh!

datadog-datadog-prod-us1 bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BeltranBulbarellaDD commented Dec 18, 2025

Uh oh!

chatgpt-codex-connector bot commented Dec 18, 2025

Uh oh!

BeltranBulbarellaDD commented Dec 31, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

BeltranBulbarellaDD commented Jan 2, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

BeltranBulbarellaDD commented Jan 5, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

BeltranBulbarellaDD Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

BeltranBulbarellaDD commented Jan 5, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

BeltranBulbarellaDD commented Jan 5, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

BeltranBulbarellaDD commented Jan 6, 2026

Uh oh!

chatgpt-codex-connector bot commented Jan 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BeltranBulbarellaDD commented Dec 17, 2025 •

edited

Loading

cit-pr-commenter bot commented Dec 17, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Dec 17, 2025 •

edited

Loading