Skip to content

Conversation

@arapulido
Copy link
Collaborator

Motivation

We are modifying the way we manage CLA signatures at Datadog

Changes

This PR introduces a new GitHub action to request contributors to sign Datadog's CLA by adding a comment to their first PR in the repository.

Test instructions

Once merged, I can test it by creating a no-op PR and sign the CLA myself

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@arapulido arapulido requested a review from a team as a code owner December 4, 2025 10:18
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +10 to +14
permissions:
contents: read
pull-requests: write
id-token: write # Needed to federate tokens.
actions: write

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Grant issues:write so CLA bot can comment

The contributor-assistant step comments on pull requests to request or acknowledge CLA signatures, but the workflow’s explicit permissions block grants only contents, pull-requests, id-token, and actions. When permissions are declared, all others default to none, so the GITHUB_TOKEN lacks issues: write, which GitHub requires for creating PR/issue comments. On pull_request_target or issue_comment runs, the bot will fail with a 403 when trying to post the CLA reminder or confirmation, preventing the CLA check from functioning.

Useful? React with 👍 / 👎.

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 4, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 164.16 KiB 164.16 KiB 0 B 0.00%
Rum Profiler 4.84 KiB 4.84 KiB 0 B 0.00%
Rum Recorder 19.62 KiB 19.62 KiB 0 B 0.00%
Logs 55.96 KiB 55.96 KiB 0 B 0.00%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 121.42 KiB 121.42 KiB 0 B 0.00%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.0064 0.0056 -12.50%
RUM - add action 0.0142 0.0124 -12.68%
RUM - add error 0.0198 0.0119 -39.90%
RUM - add timing 0.0034 0.0029 -14.71%
RUM - start view 0.0052 0.0037 -28.85%
RUM - start/stop session replay recording 0.0012 0.0007 -41.67%
Logs - log message 0.021 0.0144 -31.43%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 25.52 KiB 25.30 KiB -230 B
RUM - add action 49.16 KiB 48.53 KiB -641 B
RUM - add timing 23.92 KiB 24.89 KiB +985 B
RUM - add error 54.21 KiB 52.45 KiB -1.76 KiB
RUM - start/stop session replay recording 23.64 KiB 24.13 KiB +500 B
RUM - start view 425.48 KiB 423.37 KiB -2.11 KiB
Logs - log message 44.64 KiB 42.99 KiB -1.65 KiB

🔗 RealWorld

@datadog-datadog-prod-us1
Copy link

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 92.63% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9175aa5 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@arapulido
Copy link
Collaborator Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 4, 2025

View all feedbacks in Devflow UI.

2025-12-04 15:42:07 UTC ℹ️ Start processing command /merge


2025-12-04 15:42:11 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).


2025-12-04 16:06:59 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit c632a18 into main Dec 4, 2025
22 checks passed
@dd-mergequeue dd-mergequeue bot deleted the ara.pulido/cla branch December 4, 2025 16:06
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants