-
Notifications
You must be signed in to change notification settings - Fork 166
📝 improve API documentation #3894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 4c7b843 | Docs | Was this helpful? Give us feedback! |
| export { Logger, HandlerType } from '../domain/logger' | ||
| export { StatusType } from '../domain/logger/isAuthorized' | ||
| export type { LoggerConfiguration, LogsPublicApi as LogsGlobal } from '../boot/logsPublicApi' | ||
| export type { LoggerConfiguration, LogsPublicApi as DatadogLogs } from '../boot/logsPublicApi' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ question: Isn't it a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We exported the LogsGlobal as deprecated a few lines below (same for RUM):
/**
* @deprecated Use {@link DatadogLogs} instead
*/
export type LogsGlobal = LogsPublicApi
Motivation
Various small improvements for the API documentation done during the Mob programming session.
Changes
API/RumGlobal,Configuration/RumInitConfiguration)MainandErrorRumGlobaltoDatadogRumso that the name matches the export from NPM. (and the same for log)Test instructions
Checklist