-
Notifications
You must be signed in to change notification settings - Fork 166
👷 [mob-session] make test-performances more resilient
#3862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: e05743b | Docs | Was this helpful? Give us feedback! |
bef08fc to
bbc7828
Compare
a31f55d to
b660b33
Compare
b660b33 to
dea3dec
Compare
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
46b5223 to
1acd6eb
Compare
1acd6eb to
06c26f9
Compare
test-performances more resilienttest-performances more resilient
| localMemoryPerformances: PerformanceMetric[] | ||
| }) { | ||
| return markdownArray({ | ||
| headers: ['Action Name', 'Base Consumption Memory (bytes)', 'Local Consumption Memory (bytes)', '𝚫 (bytes)'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥜 nitpick:
- values are formatted and includes the unit, so
(bytes)is unecessary - The phrasing is a bit weird (maybe even incorrect),
Base memory consumptionwould be better
| headers: ['Action Name', 'Base Consumption Memory (bytes)', 'Local Consumption Memory (bytes)', '𝚫 (bytes)'], | |
| headers: ['Action Name', 'Base Memory Consumption', 'Local Memory Consumption', '𝚫'], |
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
The expected merge time in
|
Motivation
The "bundle sizes" PR comment was proven very valuable, however the
test-performancesjob is sometimes failing.Changes
Make the
test-performancesscript more resilient by clearly separating the three tasks (bundle sizes, memory and CPU). Each task can update its own part of the PR comment, so if a task fails it doesn't prevent the other tasks to succeed.Test instructions
See this PR comment
Checklist