Skip to content

Conversation

@BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Sep 19, 2025

Motivation

The "bundle sizes" PR comment was proven very valuable, however the test-performances job is sometimes failing.

Changes

Make the test-performances script more resilient by clearly separating the three tasks (bundle sizes, memory and CPU). Each task can update its own part of the PR comment, so if a task fails it doesn't prevent the other tasks to succeed.

Test instructions

See this PR comment

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@datadog-official
Copy link

datadog-official bot commented Sep 19, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 92.48% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e05743b | Docs | Was this helpful? Give us feedback!

@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/push-opprywwrmluq branch 5 times, most recently from bef08fc to bbc7828 Compare September 19, 2025 13:25
@DataDog DataDog deleted a comment from cit-pr-commenter bot Sep 19, 2025
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/push-opprywwrmluq branch 5 times, most recently from a31f55d to b660b33 Compare September 19, 2025 15:02
@DataDog DataDog deleted a comment from cit-pr-commenter bot Sep 19, 2025
@DataDog DataDog deleted a comment from cit-pr-commenter bot Sep 19, 2025
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/push-opprywwrmluq branch from b660b33 to dea3dec Compare September 19, 2025 15:53
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Sep 19, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 161.20 KiB 161.20 KiB 0 B 0.00%
Rum Recorder 19.53 KiB 19.53 KiB 0 B 0.00%
Rum Profiler 5.32 KiB 5.32 KiB 0 B 0.00%
Logs 55.94 KiB 55.94 KiB 0 B 0.00%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 118.73 KiB 118.73 KiB 0 B 0.00%
Worker 23.60 KiB 23.60 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫 (%)
RUM - add global context 0.009 0.0067 -25.56%
RUM - add action 0.026 0.0162 -37.69%
RUM - add error 0.025 0.0149 -40.40%
RUM - add timing 0.0066 0.0044 -33.33%
RUM - start view 0.008 0.0048 -40.00%
RUM - start/stop session replay recording 0.0017 0.001 -41.18%
Logs - log message 0.0373 0.0174 -53.35%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 25.54 KiB 24.77 KiB -790 B
RUM - add action 86.40 KiB 44.46 KiB -42941 B
RUM - add timing 24.71 KiB 24.96 KiB +255 B
RUM - add error 96.26 KiB 50.49 KiB -46864 B
RUM - start/stop session replay recording 24.06 KiB 24.20 KiB +140 B
RUM - start view 436.84 KiB 431.32 KiB -5653 B
Logs - log message 95.17 KiB 99.27 KiB +4.10 KiB

🔗 RealWorld

@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/push-opprywwrmluq branch 4 times, most recently from 46b5223 to 1acd6eb Compare September 19, 2025 17:05
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/push-opprywwrmluq branch from 1acd6eb to 06c26f9 Compare September 19, 2025 19:06
@BenoitZugmeyer BenoitZugmeyer changed the title [Mob] 👷 make test-performances more resilient Sep 22, 2025
@BenoitZugmeyer BenoitZugmeyer changed the title 👷 make test-performances more resilient 👷 [mob-session] make test-performances more resilient Sep 22, 2025
@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review September 22, 2025 07:59
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner September 22, 2025 07:59
localMemoryPerformances: PerformanceMetric[]
}) {
return markdownArray({
headers: ['Action Name', 'Base Consumption Memory (bytes)', 'Local Consumption Memory (bytes)', '𝚫 (bytes)'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥜 nitpick:

  • values are formatted and includes the unit, so (bytes) is unecessary
  • The phrasing is a bit weird (maybe even incorrect), Base memory consumption would be better
Suggested change
headers: ['Action Name', 'Base Consumption Memory (bytes)', 'Local Consumption Memory (bytes)', '𝚫 (bytes)'],
headers: ['Action Name', 'Base Memory Consumption', 'Local Memory Consumption', '𝚫'],

@BenoitZugmeyer
Copy link
Member Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Sep 22, 2025

View all feedbacks in Devflow UI.

2025-09-22 09:56:10 UTC ℹ️ Start processing command /merge


2025-09-22 09:56:16 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-09-22 10:31:18 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 33m (p90).


2025-09-22 10:52:02 UTC ℹ️ MergeQueue: This merge request was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants