-
Notifications
You must be signed in to change notification settings - Fork 166
[RUM Profiler] send view names as event attributes #3851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RUM Profiler] send view names as event attributes #3851
Conversation
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: b98b08e | Docs | Was this helpful? Give us feedback! |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
| id: sessionId, | ||
| } | ||
| } | ||
| const viewIds = Array.from(new Set(profilerTrace.views.map((viewEntry) => viewEntry.viewId))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: view ids were de-duplicated. It's not needed anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's not needed yes. I don't see how we could generate duplicated ids 🤔
Motivation
We want to allow filtering by view name in the Profiling explorer (ie.
@view.name:/my-view).In order to make the view name query-able, we need to pass it as the event's attributes (just as we do for view ids)
Changes
view.nameattribute in the Profile'sevent.jsonsent to intake.Test instructions
event.jsonsent includes the newview.nameattribute.@view.name:<the-view-you-were-browsing>and you should see a Flame Graph.Checklist