-
Notifications
You must be signed in to change notification settings - Fork 166
👷[RUM-11488] enforce specifying an expiration date for temporary telemetry #3825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 49bdbb4 | Docs | Was this helpful? Give us feedback! |
89a69da to
3b694d9
Compare
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
500ca9c to
5ecf006
Compare
5ecf006 to
c0fa09d
Compare
bcaudan
commented
Sep 22, 2025
bcaudan
commented
Sep 22, 2025
bcaudan
commented
Sep 22, 2025
packages/rum-core/src/domain/view/viewMetrics/startInitialViewMetricsTelemetry.ts
Outdated
Show resolved
Hide resolved
bcaudan
commented
Sep 22, 2025
bcaudan
commented
Sep 22, 2025
sethfowler-datadog
approved these changes
Sep 22, 2025
Contributor
sethfowler-datadog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; thank you for adding this!
packages/rum-core/src/domain/view/viewMetrics/startInitialViewMetricsTelemetry.ts
Outdated
Show resolved
Hide resolved
ec76837 to
49bdbb4
Compare
BenoitZugmeyer
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Avoid to collect unnecessary telemetry
Changes
monitor-untilcommentscheck-expired-telemetryscheduled jobTest instructions
Checklist