Skip to content

Conversation

@bcaudan
Copy link
Collaborator

@bcaudan bcaudan commented Sep 5, 2025

Motivation

Avoid to collect unnecessary telemetry

Changes

  • add an eslint rule to enforce monitor-until comments
  • specify dates for existing telemetry
  • add a check-expired-telemetry scheduled job

Test instructions

  • new telemetry without comment should trigger the eslint rule
  • a monitor-until comment with a date in the past should trigger the eslint rule

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@datadog-official
Copy link

datadog-official bot commented Sep 5, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 92.53% (+0.03%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 49bdbb4 | Docs | Was this helpful? Give us feedback!

@bcaudan bcaudan force-pushed the bcaudan/telemetry-expiration branch 3 times, most recently from 89a69da to 3b694d9 Compare September 19, 2025 14:46
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Sep 19, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum N/A 161.54 KiB N/A N/A N/A
Rum Recorder N/A 19.43 KiB N/A N/A N/A
Rum Profiler N/A 5.32 KiB N/A N/A N/A
Logs N/A 55.79 KiB N/A N/A N/A
Flagging N/A 944 B N/A N/A N/A
Rum Slim N/A 119.19 KiB N/A N/A N/A
Worker N/A 23.60 KiB N/A N/A N/A
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫 (%)
addglobalcontext N/A 0.0061 N/A
addaction N/A 0.0165 N/A
adderror N/A 0.0182 N/A
addtiming N/A 0.0048 N/A
startview N/A 0.0053 N/A
startstopsessionreplayrecording N/A 0.001 N/A
logmessage N/A 0.0284 N/A
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
addglobalcontext N/A 25.09 KiB N/A
addaction N/A 45.12 KiB N/A
addtiming N/A 24.92 KiB N/A
adderror N/A 49.64 KiB N/A
startstopsessionreplayrecording N/A 24.01 KiB N/A
startview N/A 429.70 KiB N/A
logmessage N/A 97.17 KiB N/A

🔗 RealWorld

@bcaudan bcaudan force-pushed the bcaudan/telemetry-expiration branch 2 times, most recently from 500ca9c to 5ecf006 Compare September 19, 2025 16:06
@bcaudan bcaudan force-pushed the bcaudan/telemetry-expiration branch from 5ecf006 to c0fa09d Compare September 22, 2025 11:30
@bcaudan bcaudan marked this pull request as ready for review September 22, 2025 11:50
@bcaudan bcaudan requested a review from a team as a code owner September 22, 2025 11:50
Copy link
Contributor

@sethfowler-datadog sethfowler-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thank you for adding this!

@bcaudan bcaudan force-pushed the bcaudan/telemetry-expiration branch from ec76837 to 49bdbb4 Compare September 23, 2025 09:37
@bcaudan bcaudan merged commit 7776ffa into main Sep 23, 2025
20 checks passed
@bcaudan bcaudan deleted the bcaudan/telemetry-expiration branch September 23, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants