Allow rake to remove toolchaing, clean before testing #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've hit two problems: 1. Running `rake` then `rake test` would fail[1]. To address this I run `codegen:clean` before test 2. Runig `rake codegen:clean` would fail[2]. To address this I add write permission to the toolchain dir before attemmpting to remove it. [1] ```bash $ rake test 2 go list ./... | grep -v vendor | xargs go test -v 3 pattern ./...: directory toolchains/pkg/mod/github.com/fatih/camelcase@v1.0.0 outside main module or its selected dependencies ``` [2] ```bash $ rake codegen:clean rm -rf /Users/joachim.bartosik/go/src/github.com/DataDog/agent-payload/toolchains/gogo rm -rf /Users/joachim.bartosik/go/src/github.com/DataDog/agent-payload/toolchains rm: cannot remove '/Users/joachim.bartosik/go/src/github.com/DataDog/agent-payload/toolchains/pkg/mod/github.com/envoyproxy/protoc-gen-validate@v0.10.1/main.go': Permission denied rake aborted! Command failed with status (1): [rm -rf /Users/joachim.bartosik/go/src/gith...] /Users/joachim.bartosik/go/src/github.com/DataDog/agent-payload/Rakefile:36:in `block (2 levels) in <top (required)>' Tasks: TOP => codegen:clean (See full trace by running task with --trace) ```
GustavoCaso
reviewed
Oct 14, 2024
| @@ -33,6 +33,9 @@ protoc_jsonschema_version="73d5723" | |||
| namespace :codegen do | |||
| task :clean do | |||
| sh "rm -rf #{gogo_dir}" | |||
| if Dir.exist?(toolchain_dir) | |||
| sh "chmod u+w -R #{toolchain_dir}" | |||
There was a problem hiding this comment.
Quetsion: Would it make more sense to add the permissions in the task that generates the proto files?
There was a problem hiding this comment.
I'm new here but I think that this is a good way to go around this - in most cases we don't want to overwrite anything in the directory so it's readonly
GustavoCaso
approved these changes
Oct 29, 2024
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've hit two problems:
rakethenrake testwould fail[1]. To address this I runcodegen:cleanbefore testrake codegen:cleanwould fail[2]. To address this I add write permission to the toolchain dir before attemmpting to remove it.[1]
[2]
Motivation
I want to run
rake testand have it work.Reviewers: please see the review guidelines.