Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NPM-3609] Add more comments to connections.proto #341

Merged
merged 1 commit into from
Sep 11, 2024
Merged

[NPM-3609] Add more comments to connections.proto #341

merged 1 commit into from
Sep 11, 2024

Conversation

leeavital
Copy link
Contributor

What does this PR do?

Motivation

This payload is hard to reason about!

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

Reviewers: please see the review guidelines.

@leeavital leeavital marked this pull request as ready for review September 5, 2024 22:00
@leeavital leeavital requested review from a team as code owners September 5, 2024 22:00
akarpz
akarpz approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@akarpz akarpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@leeavital
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 6, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Sep 7, 2024

⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

@leeavital leeavital force-pushed the lee.avital/more_connection_proto_comments branch from 87f7289 to bdcf43c Compare September 11, 2024 14:07
@leeavital
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 11, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Sep 11, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in master is 2m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 55fa918 into master Sep 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akarpz akarpz akarpz approved these changes

@sgnn7 sgnn7 sgnn7 approved these changes

Assignees
No one assigned
Labels
mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leeavital @sgnn7 @akarpz