Skip to content

Commit

Permalink
Remove python codegen
Browse files Browse the repository at this point in the history
This is safe because the only python consumer (in the backend) copies the protobuf definition from this repo and re-generates python code.
  • Loading branch information
leeavital committed Sep 20, 2024
1 parent 55fa918 commit cb0e6fd
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 935 deletions.
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Payload format description for communication between the Agent and the Datadog b

This repository includes the protocol-buffer IDL used by the agent6 and agent7 to communicate with the Datadog backend.
Those payloads are only supported by the V2 API endpoints.
The generated Go, Python and Java implementations are checked into this repository and can be used directly.
The generated Go, and Java implementations are checked into this repository and can be used directly. Other consumers may copy the `.proto` files into their repository and generate their own bindings.

# Prerequisites

Expand All @@ -27,7 +27,6 @@ The following implementations are available:
The metrics payload is defined in [`proto/metrics/agent_payload.proto`](./proto/metrics/agent_payload.proto).
The following implementations are available:
* Go (gogofast): [github.com/DataDog/agent-payload/gogen](https://pkg.go.dev/github.com/DataDog/agent-payload/gogen)
* Python: [`python/agent_payload_pb2.py`](./python/agent_payload_pb2.py)

## Process

Expand Down
3 changes: 0 additions & 3 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,6 @@ BASH
PATH=#{toolchain_bin_dir} #{protoc_binary} --proto_path=$GOPATH/src:#{gogo_include}:#{toolchain_include_dir}:. --gogofast_out=$GOPATH/src proto/metrics/agent_payload.proto
echo "done"
echo "Generating metrics proto (python)"
PATH=#{toolchain_bin_dir} #{protoc_legacy_binary} --proto_path=#{toolchain_legacy_include_dir}:#{gogo_include}:./proto/metrics --python_out=python agent_payload.proto
echo "Generating process proto (go)"
PATH=#{toolchain_bin_dir} #{protoc_binary} --proto_path=#{toolchain_include_dir}:#{gogo_include}:. --gogofaster_out=$GOPATH/src proto/process/*.proto
Expand Down
Loading

0 comments on commit cb0e6fd

Please sign in to comment.