fix grpc ingestor (backward compat) #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minosity-VR
approved these changes
Sep 13, 2024
| @@ -124,7 +124,7 @@ func (g *IngestorAPI) Ingest(_ context.Context, path string) error { | |||
| if err != nil { | |||
| log.I.Warnf("no metadata has been parsed (old dump format from v1.4.0 or below do not embed metadata information): %v", err) | |||
| // Backward Compatibility: Extracting the metadata from the path | |||
| dumpMetadata, err := dump.ParsePath(archivePath) | |||
There was a problem hiding this comment.
Not sure to understand why this change it needed, in the unit test iirc you did an example with the .tar.gz file
There was a problem hiding this comment.
because the archivePath is an hardcoden string, so we need to parse the key which contains the clustername and runid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of
metadata.jsonin v1.5.0, we need to have retro compatibility with old dumps. So I clean the old args and patch with the key path to extract the metadata information.