adding config command #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edznux-dd
reviewed
Aug 7, 2024
cmd/kubehound/config.go
Outdated
| configCmd = &cobra.Command{ | ||
| Use: "config", | ||
| Short: "Show the current configuration", | ||
| Long: `[devOnly] Spawn the kubehound dev stack for the system-tests (build from dockerfile)`, |
cmd/kubehound/config.go
Outdated
| return nil | ||
| } | ||
|
|
||
| fmt.Println(" --- YAML ---") //nolint:forbidigo |
There was a problem hiding this comment.
Isn't it confusing that you use --- since it's also the "start of document" in yaml? But at the same time the rest of the line should fail since it's not valid yaml (and it also has a space prefixed, that might be a typo)?
| "github.com/DataDog/KubeHound/pkg/cmd" | ||
| "github.com/DataDog/KubeHound/pkg/telemetry/log" | ||
| "github.com/spf13/cobra" | ||
| "gopkg.in/yaml.v2" |
There was a problem hiding this comment.
I guess we have this dep already so it's fine, but otherwise I'd ask the reason of not being on v3.
Minosity-VR
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a
configcommand to view the current config KubeHound (with a flag--pathto dump the content):