Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding local config file #233

Merged
merged 8 commits into from
Jul 30, 2024
Merged

Adding local config file #233

merged 8 commits into from
Jul 30, 2024

Conversation

jt-dd
Copy link
Contributor

@jt-dd jt-dd commented Jul 30, 2024

Adding a local config file to enter some fixed variable that can be overwritten with flags. This new file is mainly for the khaas configuration:

  • khaas-server: api endpoint
  • bucket: configuration of the remote storage

Also this can be used to have custom configuration for the dumper for instance. This reuse the same mechasnism as previously used to load a custom configuration file with the -c config.

edznux-dd
edznux-dd previously approved these changes Jul 30, 2024
Copy link
Contributor

@edznux-dd edznux-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add an example of the khaas setting in the example config files?

@jt-dd jt-dd requested a review from edznux-dd July 30, 2024 14:02
@jt-dd jt-dd marked this pull request as ready for review July 30, 2024 14:02
@jt-dd jt-dd requested a review from a team as a code owner July 30, 2024 14:02
@jt-dd jt-dd merged commit 8ae59ac into main Jul 30, 2024
8 checks passed
@jt-dd jt-dd deleted the jt-dd/local-config-file branch July 30, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants