Use positionnal argument for directory/file input/output path #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edznux-dd
previously approved these changes
Jul 30, 2024
Co-authored-by: Edouard Schweisguth <edouard.schweisguth@datadoghq.com>
Minosity-VR
reviewed
Jul 30, 2024
pkg/cmd/dump.go
Outdated
| cmd.Flags().String("output-dir", "", "Directory to dump the data") | ||
| viper.BindPFlag(config.CollectorFileDirectory, cmd.Flags().Lookup("output-dir")) //nolint: errcheck | ||
| cmd.MarkFlagRequired("output-dir") //nolint: errcheck | ||
| cmd.Flags().Bool("no-compress", false, "Enable compression for the dumped data (generates a tar.gz file)") |
There was a problem hiding this comment.
I feel the name no-compress tells the opposite of Enable compression
…DataDog/kubehound into jt-dd/modifying-inputs-args-flags
edznux-dd
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the flags for the input/output for
ingest localanddump local. Now it will get passed through the first argument:kubehound dump local [directory to dump the data]kubehound ingest local [directory or tar.gz path] --cluster <cluster_name>Also now the default behavior is to create a compressed file. So the
--compresshas been changed to--no-compress.Note: another PR will be made for the docs