[RC4] Fix for datadog logs output #196
Conversation
There was a problem hiding this comment.
I would rather have a switch for JSON logging that something indirect based on the env.
I could then be wrapped by the config load for the prod env, but mixing the 2 is not great semantically.
If user want to use json logging, they will have to setup DD_ENV= something, which is weird.
We have a config file, imo that should be put there:
log_format:"json", log_format:"text" seems simple to implement as well.
pkg/globals/application.go
Outdated
| func IsDDFormat() bool { | ||
| _, isDDEnv := os.LookupEnv("DD_ENV") | ||
|
|
||
| return isDDEnv |
There was a problem hiding this comment.
Not a huge fan of IsDDFormat here, what format is it? (I know it's for the logs because this PR says it, but it's a global func)
There was a problem hiding this comment.
ok I just reuse what was in place. Did not like the ProdEnv() func. Will see if it is not too painful to add it to the config file instead.
Fix to set the output for the datadog agent:
DD_ENVenv var needs to be set to activate the json outputDD_ENVwill set the datadog tagsenv