[Dumper] Rework of the object ingestion #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edznux-dd
previously approved these changes
Mar 18, 2024
Comment on lines
+87
to
+92
| // err = pipeline.Run(ctx) | ||
| // if err != nil { | ||
| // return fmt.Errorf("run pipeline ingestor: %w", err) | ||
| // } | ||
|
|
||
| return nil | ||
| // return pipeline.Wait(ctx) |
There was a problem hiding this comment.
This is commented for the next PR?
There was a problem hiding this comment.
yes it is. to have a "pain less" split.
edznux-dd
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create an interface for each object type to add the ability to create an objectList for each k8s type. For instance all endpoint stack them into a discoveryv1.EndpointSliceList. This is needed by the collector.
Effort were already made to be fully supported by the writers (tar and file one).