Skip to content

Commit 662bee4

Browse files
MillenniumFalconMechanicNoopDog
authored andcommitted
Updated prepared matrix download UI from data table. Resolves #987. (#1014)
* Added download matrix modal functionality. Resolves #987. * Tests added for ProjectDownloadMatrix and FileDownload. #987. * Updated prepared matrix download UI from data table. Resolves #987.
1 parent b4abd13 commit 662bee4

File tree

61 files changed

+1393
-347
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

61 files changed

+1393
-347
lines changed

spa/src/app/files/files.component.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
2-
* UCSC Genomics Institute - CGL
3-
* https://cgl.genomics.ucsc.edu/
2+
* Human Cell Atlas
3+
* https://www.humancellatlas.org/
44
*
55
* Files component styles.
66
*/
@@ -11,7 +11,7 @@
1111
flex: 1; // Push footer to bottom of available space (inside snapper)
1212

1313
.layout-column {
14-
display: flex; // Required to display <project-prepared-matrix-downloads>
14+
//display: flex; // Required to display <project-prepared-matrix-downloads>
1515
height: 100%; // Required for download banner hca-download-manifest
1616
}
1717

spa/src/app/files/files.module.ts

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
*/
77

88
// Core dependencies
9-
import { ClipboardModule } from "ngx-clipboard";
109
import { NgModule } from "@angular/core";
1110
import { FormsModule, ReactiveFormsModule } from "@angular/forms";
1211
import { HttpClientModule } from "@angular/common/http";
@@ -18,6 +17,7 @@ import { MatButtonModule } from "@angular/material/button";
1817
import { MatCardModule } from "@angular/material/card";
1918
import { MatCheckboxModule } from "@angular/material/checkbox";
2019
import { MatChipsModule } from "@angular/material/chips";
20+
import { MatDialogModule } from "@angular/material";
2121
import { MatFormFieldModule } from "@angular/material/form-field";
2222
import { MatIconModule } from "@angular/material/icon";
2323
import { MatInputModule } from "@angular/material/input";
@@ -50,7 +50,6 @@ import { HCAFileSummaryComponent } from "./hca-file-summary/hca-file-summary.com
5050
import { HCAGetDataComponent } from "./hca-get-data/hca-get-data.component";
5151
import { HCAGetDataDownloadsComponent } from "./hca-get-data/hca-get-data-downloads/hca-get-data-downloads.component";
5252
import { HCAGetDataPanelComponent } from "./hca-get-data/hca-get-data-panel/hca-get-data-panel.component";
53-
import { CopyToClipboardComponent } from "./hca-get-data/copy-to-clipboard/copy-to-clipboard.component";
5453
import { HCAGetDataFileSummaryComponent } from "./hca-get-data/hca-get-data-file-summary/hca-get-data-file-summary.component";
5554
import { HCAGetDataSummaryComponent } from "./hca-get-data/hca-get-data-summary/hca-get-data-summary.component";
5655
import { HCAGetManifestComponent } from "./hca-get-data/hca-get-manifest/hca-get-manifest.component";
@@ -76,11 +75,12 @@ import { HCATableSortComponent } from "./hca-table-sort/hca-table-sort.component
7675
import { HCATooltipComponent } from "./hca-tooltip/hca-tooltip.component";
7776
import { ProjectService } from "./project/project.service";
7877
import { ProjectDeprecatedComponent } from "./project-deprecated/project-deprecated.component";
79-
import { ProjectDownloadsComponent } from "./project-downloads/project-downloads.component";
78+
import { ProjectDownloadMatrixModalContainerComponent } from "./project-download-matrix-modal-container/project-download-matrix-modal-container.component";
79+
import { ProjectDownloadMatrixModalComponent } from "./project-download-matrix-modal/project-download-matrix-modal.component";
80+
import { ProjectDownloadMatrixComponent } from "./project-download-matrix/project-download-matrix.component";
8081
import { ProjectGuardComponent } from "./project-guard/project-guard.component";
8182
import { ProjectIntegrationsComponent } from "./project-integrations/project-integrations.component";
8283
import { ProjectIngestInProgressComponent } from "./project-ingest-in-progress/project-ingest-in-progress.component";
83-
import { ProjectPreparedMatrixDownloadsComponent } from "./project-prepared-matrix-downloads/project-prepared-matrix-downloads.component";
8484
import { ProjectTSVDownloadComponent } from "./project-tsv-download/project-tsv-download.component";
8585
import { SearchTermService } from "./shared/search-term.service";
8686
import { DownloadService } from "./shared/download.service";
@@ -100,13 +100,13 @@ import { TableScroll } from "./table-scroll/table-scroll.component";
100100
@NgModule({
101101
imports: [
102102
BrowserAnimationsModule,
103-
ClipboardModule,
104103
FormsModule,
105104
MatAutocompleteModule,
106105
MatButtonModule,
107106
MatCardModule,
108107
MatCheckboxModule,
109108
MatChipsModule,
109+
MatDialogModule,
110110
MatFormFieldModule,
111111
MatIconModule,
112112
MatInputModule,
@@ -127,7 +127,6 @@ import { TableScroll } from "./table-scroll/table-scroll.component";
127127
SharedModule
128128
],
129129
declarations: [
130-
131130
AnalysisProtocolPipelineLinkerComponent,
132131
FileTypeSummaryListComponent,
133132
FileManifestSummaryComponent,
@@ -147,16 +146,16 @@ import { TableScroll } from "./table-scroll/table-scroll.component";
147146
MatrixUrlRequestFormComponent,
148147
MatrixUrlRequestCompletedComponent,
149148
ProjectDeprecatedComponent,
150-
ProjectDownloadsComponent,
151149
ProjectGuardComponent,
152150
ProjectIngestInProgressComponent,
153151
ProjectIntegrationsComponent,
154152
ProjectTSVDownloadComponent,
155-
ProjectPreparedMatrixDownloadsComponent,
153+
ProjectDownloadMatrixComponent,
154+
ProjectDownloadMatrixModalComponent,
155+
ProjectDownloadMatrixModalContainerComponent,
156156
HCAGetDataComponent,
157157
HCAGetDataDownloadsComponent,
158158
HCAGetDataPanelComponent,
159-
CopyToClipboardComponent,
160159
HCAGetDataFileSummaryComponent,
161160
HCAGetDataSummaryComponent,
162161
HCAGetManifestComponent,
@@ -179,6 +178,9 @@ import { TableScroll } from "./table-scroll/table-scroll.component";
179178
HCAFileSummaryComponent,
180179
TableScroll
181180
],
181+
entryComponents: [
182+
ProjectDownloadMatrixModalComponent
183+
],
182184
providers: [
183185
ConfigService,
184186
DownloadService,

spa/src/app/files/files.routes.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import { Route } from "@angular/router";
1111
// App dependencies
1212
import { FilesComponent } from "./files.component";
1313
import { HCAGetDataComponent } from "./hca-get-data/hca-get-data.component";
14+
import { ProjectDownloadMatrixModalContainerComponent } from "./project-download-matrix-modal-container/project-download-matrix-modal-container.component";
1415
import { ProjectGuardComponent } from "./project-guard/project-guard.component";
1516

1617
export const routes: Route[] = [
@@ -38,6 +39,10 @@ export const routes: Route[] = [
3839
path: ":id",
3940
component: ProjectGuardComponent
4041

42+
},
43+
{
44+
path: ":id/prepared-expression-matrices",
45+
component: ProjectDownloadMatrixModalContainerComponent
4146
}
4247
]
4348
}

spa/src/app/files/hca-get-data/hca-export-to-terra/hca-export-to-terra.component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import { SearchTermService } from "../../shared/search-term.service";
2626
import { TermResponseService } from "../../shared/term-response.service";
2727
import { TerraService } from "../../shared/terra.service";
2828
import { TermSortService } from "../../sort/term-sort.service";
29-
import { CopyToClipboardComponent } from "../copy-to-clipboard/copy-to-clipboard.component";
29+
import { CopyToClipboardComponent } from "../../../shared/copy-to-clipboard/copy-to-clipboard.component";
3030
import { HCAGetDataPanelComponent } from "../hca-get-data-panel/hca-get-data-panel.component";
3131
import { HCAExportToTerraComponent } from "./hca-export-to-terra.component";
3232

spa/src/app/files/hca-get-data/hca-get-manifest/hca-get-manifest.component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import { FileTypeSummaryListComponent } from "../../file-type-summary-list/file-
2121
import { DEFAULT_FILE_SUMMARY } from "../../shared/file-summary.mock";
2222
import { ManifestStatus } from "../../shared/manifest-status.model";
2323
import { TermSortService } from "../../sort/term-sort.service";
24-
import { CopyToClipboardComponent } from "../copy-to-clipboard/copy-to-clipboard.component";
24+
import { CopyToClipboardComponent } from "../../../shared/copy-to-clipboard/copy-to-clipboard.component";
2525
import { HCAGetDataPanelComponent } from "../hca-get-data-panel/hca-get-data-panel.component";
2626
import { HCAGetManifestComponent } from "./hca-get-manifest.component";
2727
import { SearchFileFacetTerm } from "../../search/search-file-facet-term.model";

spa/src/app/files/hca-get-data/hca-get-matrix/hca-get-matrix.component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import { MatrixUrlRequestStatus } from "../../shared/matrix-url-request-status.m
3030
import { CancelFetchMatrixUrlRequestAction } from "../../_ngrx/matrix/cancel-fetch-matrix-url-request.action";
3131
import { ClearMatrixPartialQueryMatchAction } from "../../_ngrx/matrix/clear-matrix-partial-query-match.action";
3232
import { FetchMatrixUrlRequestAction } from "../../_ngrx/matrix/fetch-matrix-url-request.action";
33-
import { CopyToClipboardComponent } from "../copy-to-clipboard/copy-to-clipboard.component";
33+
import { CopyToClipboardComponent } from "../../../shared/copy-to-clipboard/copy-to-clipboard.component";
3434
import { HCAGetDataPanelComponent } from "../hca-get-data-panel/hca-get-data-panel.component";
3535
import { MatrixPartialQueryMatchWarningComponent } from "../matrix-partial-query-match-warning/matrix-partial-query-match-warning.component";
3636
import { MatrixUrlRequestCompletedComponent } from "../matrix-url-request-completed/matrix-url-request-completed.component";

spa/src/app/files/hca-get-data/matrix-url-request-completed/matrix-url-request-completed.component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import { ConfigService } from "../../../config/config.service";
1818
import { FileManifestService } from "../../shared/file-manifest.service";
1919
import { MatrixService } from "../../shared/matrix.service";
2020
import { MatrixUrlRequestStatus } from "../../shared/matrix-url-request-status.model";
21-
import { CopyToClipboardComponent } from "../copy-to-clipboard/copy-to-clipboard.component";
21+
import { CopyToClipboardComponent } from "../../../shared/copy-to-clipboard/copy-to-clipboard.component";
2222
import { HCAGetDataPanelComponent } from "../hca-get-data-panel/hca-get-data-panel.component";
2323
import { MatrixUrlRequestCompletedComponent } from "./matrix-url-request-completed.component";
2424

spa/src/app/files/hca-get-data/matrix-url-request-form/matrix-url-request-form.component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import { WarningComponent } from "../../../shared/warning/warning.component";
1919
import { WarningContentComponent } from "../../../shared/warning/warning-content.component";
2020
import { WarningTitleComponent } from "../../../shared/warning/warning-title.component";
2121
import { MatrixFormat } from "../../shared/matrix-format.model";
22-
import { CopyToClipboardComponent } from "../copy-to-clipboard/copy-to-clipboard.component";
22+
import { CopyToClipboardComponent } from "../../../shared/copy-to-clipboard/copy-to-clipboard.component";
2323
import { HCAGetDataPanelComponent } from "../hca-get-data-panel/hca-get-data-panel.component";
2424
import { MatrixPartialQueryMatchWarningComponent } from "../matrix-partial-query-match-warning/matrix-partial-query-match-warning.component";
2525
import { MatrixUrlRequestFormComponent } from "./matrix-url-request-form.component";

spa/src/app/files/hca-project/hca-project.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ <h4 class="fontsize-m semi-bold">Project Downloads</h4>
132132
<p class="fontsize-xs rhs downloads">
133133
<span *ngFor="let matrixUrl of state.projectMatrixUrls.listMatrixUrlsBySpecies(species)"><a
134134
[href]="matrixUrl.url"><img
135-
src="assets/images/icon/hca-download-primary.png"/><span>{{matrixUrl.fileType}}</span></a></span>
135+
src="assets/images/icon/hca-download-primary.png"/><span>{{matrixUrl.name}}</span></a></span>
136136
</p>
137137
</div>
138138
</div>

spa/src/app/files/hca-project/hca-project.component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import { HCASectionTitleComponent } from "../../shared/hca-section-title/hca-sec
2323
import { HCATabComponent } from "../../shared/hca-tab/hca-tab";
2424
import { PopLayoutComponent } from "../../shared/pop-layout/pop-layout.component";
2525
import { AnalysisProtocolPipelineLinkerComponent } from "../analysis-protocol-pipeline-linker/analysis-protocol-pipeline-linker.component";
26-
import { CopyToClipboardComponent } from "../hca-get-data/copy-to-clipboard/copy-to-clipboard.component";
26+
import { CopyToClipboardComponent } from "../../shared/copy-to-clipboard/copy-to-clipboard.component";
2727
import { HCATooltipComponent } from "../hca-tooltip/hca-tooltip.component";
2828
import { ProjectIntegrationsComponent } from "../project-integrations/project-integrations.component";
2929
import { ProjectTSVDownloadComponent } from "../project-tsv-download/project-tsv-download.component";

0 commit comments

Comments
 (0)