Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dashlane_authenticator 2FA path #279

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Remove dashlane_authenticator 2FA path #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/endpoints/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ export * from './getTeamMembers.js';
export * from './getTeamReport.js';
export * from './listDevices.js';
export * from './listTeamDevices.js';
export * from './performDashlaneAuthenticatorVerification.js';
export * from './performDuoPushVerification.js';
export * from './performEmailTokenVerification.js';
export * from './performTotpVerification.js';
Expand Down
18 changes: 0 additions & 18 deletions src/endpoints/performDashlaneAuthenticatorVerification.ts
View file
Open in desktop

This file was deleted.

7 changes: 3 additions & 4 deletions src/modules/auth/registerDevice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { doSSOVerification } from './sso/index.js';
import { doConfidentialSSOVerification } from './confidential-sso/index.js';
import {
completeDeviceRegistration,
performDashlaneAuthenticatorVerification,
performDuoPushVerification,
performEmailTokenVerification,
performTotpVerification,
Expand All @@ -29,6 +28,9 @@ export const registerDevice = async (params: RegisterDevice) => {

const nonEmptyVerifications = verifications.filter((method) => method.type);

// Remove dashlane_authenticator from the list of verification methods as it is a deprecated method
nonEmptyVerifications.filter((method) => method.type !== 'dashlane_authenticator');

const selectedVerificationMethod =
nonEmptyVerifications.length > 1
? await askVerificationMethod(nonEmptyVerifications)
Expand All @@ -43,9 +45,6 @@ export const registerDevice = async (params: RegisterDevice) => {
if (selectedVerificationMethod.type === 'duo_push') {
logger.info('Please accept the Duo push notification on your phone.');
({ authTicket } = await performDuoPushVerification({ login }));
} else if (selectedVerificationMethod.type === 'dashlane_authenticator') {
logger.info('Please accept the Dashlane Authenticator push notification on your phone.');
({ authTicket } = await performDashlaneAuthenticatorVerification({ login }));
} else if (selectedVerificationMethod.type === 'totp') {
const otp = await askOtp();
({ authTicket } = await performTotpVerification({
Expand Down