-
-
Notifications
You must be signed in to change notification settings - Fork 3
TrenchBoot updates #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TrenchBoot updates #555
Conversation
@SergiiDmytruk, I have to automate Dasharo (coreboot+SeaBIOS) on a large scale for the upcoming PC Engine releases. @macpijan, I'm looking for your input on whether you see |
6896a82
to
000dd71
Compare
@pietrushnic Changed it in 40c9d5f, which is more reasonable and can be at least a temporary solution. |
5ba442b
to
204b560
Compare
@krystian-hebel let me know if you have more comments here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't been able to test it on HW (all apus were checked out, except for apu3 where RTE didn't start it's REST server for rte_ctrl, I've notified Dawid an he'll look into it) but running the steps manually worked. CI passed for QEMU so I'm assuming default SEABIOS_BOOT_DEVICE
also works as it should, I was afraid it may need ${EMPTY}
or some other RF magic.
Let's make pre-commit happy before merging. There is one typo and apparently something else, because it reports 2 modified files. I hope it doesn't try to un-escape what needs to be escaped...
This is what pre-commit suggests |
204b560
to
f94439b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge once you confirm it works well paired with: zarhus/meta-trenchboot#45
f94439b
to
d90020c
Compare
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Mention that it's possible to pass arbitrary parameters to `robot` after `--`. Also use parenthesis instead of brackets for the mandatory parameter and indicate that it doesn't have to be a single parameter. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Not the nicest solution, but a reasonable one. Because SeaBIOS doesn't know which drives contain which OSes, let the user specify it via `$SEABIOS_BOOT_DEVICE` variable and handle this case in `.Boot System Or From Connected Disk` keyword. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
They don't apply to Linux boot, but will be useful for Xen. Need to somehow specify what is being loaded (probably do it in a separate test). Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
This avoids relying on tpm2_eventlog to compute expected values. The problem is that it might do it wrong because some digests aren't extended into PCRs, but the tool assumes otherwise. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Previously only non-DRTM case was tested, now DRTM one works as well. It requires SeaBIOS which is harder to automate, see README file for how to use it.
See commit messages for more info.