dasharo-deploy: Add sanity check before flash #139
+48
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds last resort check before performing any flashrom commands. For heads update, we shall not proceed if FD or ME is locked. Signed-off-by: Mateusz Kusiak <mateusz.kusiak@3mdeb.com>
Contributor
Author
Example run (qemu)
Heads transiton, FD and ME disabled scenario. |
m-iwanicki
requested changes
Dec 16, 2025
| local locked_regions=() | ||
| local region_list verb | ||
|
|
||
| if [ "$BOARD_FD_REGION_RW" -eq 0 ]; then |
Contributor
There was a problem hiding this comment.
Suggested change
| if [ "$BOARD_FD_REGION_RW" -eq 0 ]; then | |
| if [[ "$BOARD_HAS_FD_REGION" -eq 1 && "$BOARD_FD_REGION_RW" -eq 0 ]]; then |
| locked_regions+=("FD") | ||
| fi | ||
|
|
||
| if [ "$BOARD_ME_REGION_RW" -eq 0 ]; then |
Contributor
There was a problem hiding this comment.
Suggested change
| if [ "$BOARD_ME_REGION_RW" -eq 0 ]; then | |
| if [[ "$BOARD_HAS_ME_REGION" -eq 1 && "$BOARD_ME_REGION_RW" -eq 0 ]]; then |
| done | ||
|
|
||
| # Last restort check before flashing | ||
| if ! flashrom_sanity_check; then |
Contributor
There was a problem hiding this comment.
I feel like it should check what really is flashed by parsing _jobs.
Contributor
There was a problem hiding this comment.
You can ignore this comment if you think it's OK.
Contributor
There was a problem hiding this comment.
I'm not sure about correctness of this implementation, will need to check cases where we only flash e.g. COREBOOT like every PC Engines. There is also Optiplex:
optiplex-7010 UEFI Update - DPP.profile:35:flashrom -p internal -N --fmap -i COREBOOT -w /tmp/biosupdateNot sure if we should warn in this case if we are not even flashing FD (because it's identical). If we are currently printing warning then it's ok.
| fi | ||
|
|
||
| if [[ "$SWITCHING_TO" == "heads" ]]; then | ||
| print_error "Cannot proceed with heads update when $region_list $verb locked!" |
Contributor
There was a problem hiding this comment.
Add link to docs with information what should be done (if it doesn't exists then add it). Maybe: https://docs.dasharo.com/guides/firmware-update/#known-issues.
For MSI (locked FD): The following warnings appear when updating Dasharo: should be good enough.
For ME you could add generic: Make sure ME is set to HAP disabled. If this doesn't work then try with ME Soft Disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add last resort check before running flashrom.
For now target is
fd_firstbranch, will change this once it gets merged.