Skip to content

Dgpu only #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 1, 2025
Merged

Dgpu only #632

merged 15 commits into from
Apr 1, 2025

Conversation

filipleple
Copy link
Member

No description provided.

mkopec
mkopec reviewed Mar 23, 2025
View reviewed changes
@filipleple filipleple force-pushed the dgpu_only branch 4 times, most recently from 061a363 to 15758a4 Compare March 27, 2025 12:18
@miczyg1 miczyg1 changed the base branch from dasharo to dasharo-24.02.1 March 28, 2025 12:10
@filipleple filipleple force-pushed the dgpu_only branch 4 times, most recently from 1eb60fa to f366f5e Compare March 31, 2025 12:26
@filipleple filipleple marked this pull request as ready for review March 31, 2025 12:46
@filipleple filipleple force-pushed the dgpu_only branch 2 times, most recently from 99510f1 to e8d1434 Compare March 31, 2025 15:07
mkopec
mkopec reviewed Mar 31, 2025
View reviewed changes
mkopec
mkopec reviewed Mar 31, 2025
View reviewed changes
mkopec
mkopec reviewed Mar 31, 2025
View reviewed changes
mkopec
mkopec reviewed Mar 31, 2025
View reviewed changes
mkopec
mkopec reviewed Mar 31, 2025
View reviewed changes
mkopec
mkopec reviewed Mar 31, 2025
View reviewed changes
mkopec
mkopec requested changes Mar 31, 2025
View reviewed changes
Copy link
Member

@mkopec mkopec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just needs a clean up of the remaining debug prints

@filipleple filipleple requested a review from mkopec April 1, 2025 08:35
@filipleple @mkopec
vendorcode/dasharo/options.c: rename DGPUEnable to DGPUState
ea79923 
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
@filipleple @mkopec
vendorcode/dasharo/options.c: add dasharo_is_dgpu_only()
a610546 
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
@filipleple @mkopec
vendorcode/dasharo/options.c: switch from dasharo_is_dgpu_enabled to …
56e65dd 
…dasharo_dgpu_state

Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
@filipleple @mkopec
mainboard/clevo/: use enum values when checking dGPU state
cfddf14 
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
@filipleple @mkopec
mainboard/clevo/mtl-h/ramstage.c: set EC dGPU only option
fd30d88 
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
filipleple added 10 commits April 1, 2025 11:51
@filipleple @mkopec
ec/system76/ec/system76_ec.c: add system76_read_option()
8415b19 
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
@filipleple @mkopec
mainboard/clevo/mtl-h/variants/dgpu/ramstage.c: dGPU only global reset
2a1cf5a 
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
@filipleple @mkopec
payloads/external/edk2/Kconfig.dasharo: EDK2_DGPU_POWER_OPTION depend…
8045a24 
…s on !EDK2_DISABLE_OPTION_ROMS

Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
@filipleple @mkopec
configs/config.novacustom_nv4x_tgl_dgpu: remove redundant config
3b57c0c 
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
@filipleple @mkopec
configs/config.novacustom_v5*0tnx: bump EDK2, fix option conflict for…
a2bf52a 
… dGPU only mode

Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
@filipleple @mkopec
payloads/external/edk2/Makefile: set PcdDgpuOnlyAvailable
34bcbbc 
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
@filipleple @mkopec
payloads/external/edk2/Makefile: fix build for non-dGPU platforms
48e1e74 
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
@filipleple @mkopec
vendorcode/dasharo/options.c: reduce extra debug prints
1f6b855 
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
@filipleple @mkopec
mainboard/clevo/mtl-h/variants/dgpu/ramstage.c: reduce extra debug pr…
d5d4d6b 
…ints

Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
@filipleple @mkopec
vendorcode/dasharo/options.c:fix dgpu_states build error
f70e0d8 
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
@mkopec mkopec merged commit f70e0d8 into dasharo-24.02.1 Apr 1, 2025
41 of 42 checks passed
@mkopec mkopec deleted the dgpu_only branch April 1, 2025 09:53
@filipleple filipleple mentioned this pull request Apr 1, 2025
Closed
@ilikenwf ilikenwf mentioned this pull request Apr 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkopec mkopec mkopec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipleple @mkopec