Skip to content

Conversation

@DashCoreAutoGuix
Copy link
Owner

Backport Details

Bitcoin Commit: 54e07a0
Bitcoin PR: bitcoin#27471
Version: 0.25
Batch: 412

Summary

This backport introduces the wallet_bumpfee.py functional test file from Bitcoin Core, including the fix for the 'spend_one_input' occasional failure.

Note: This PR adds the entire wallet_bumpfee.py test file (706 lines) because it doesn't exist yet in the batch branch. The Bitcoin commit 54e07a0 only modified 11 lines to fix a test ordering issue, but since the base file didn't exist, the cherry-pick brought in the complete file as it existed at that Bitcoin commit (with the fix already applied).

Changes

  • Introduces test/functional/wallet_bumpfee.py with the fix already applied
  • The fix moves test_feerate_checks_replaced_outputs to the end of the test suite to prevent it from consuming UTXOs needed by other subtests
  • Adds proper setup (balance funding) to the moved test function

Dependencies

This test requires the bumpfee RPC functionality to be backported first. The test will not work until those RPC commands are available in Dash Core.

Original Bitcoin Description

Most of the subtests in wallet_bumpfee.py expect to find spendable UTXOs of 0.001 btc in the rbf wallet. They use the 'spend_one_input()' method which fails if none of them exist.

The sporadic failure comes from the recently added 'test_feerate_checks_replaced_outputs' subtest that can spend all them, leaving the next subtests with no 0.001 UTXOs to spend.

To solve it, this PR moves the recently added case into a "context independent subtests" section which is placed at the end to not affect other cases.


🤖 Generated with Claude Code

Co-Authored-By: Claude noreply@anthropic.com

f24f4fa Update developer-notes.md (Riahiamirreza)

Pull request description:

ACKs for top commit:
  fanquake:
    ACK f24f4fa

Tree-SHA512: 10301170dff6f2f7b47a229ba99f4a4f4953c361be24996b6dc70343ad118879cd90ebb54d78cd31c852f577fb17f9726582fdd02ed5b6fd7b71566942e8b408
…ailure

e07dd5f test: fix bumpfee 'spend_one_input' occasional failure (furszy)

Pull request description:

  CI test failure, in master: https://cirrus-ci.com/task/5975232842825728.
  In bitcoin#27469 https://cirrus-ci.com/task/6452468402356224

  Most of the subtests in `wallet_bumpfee.py` expect to find spendable UTXOs of 0.001 btc in the rbf wallet. They use the `spend_one_input()` method which fails if none of them exist.

  The sporadic failure comes from the recently added `test_feerate_checks_replaced_outputs` subtest that can spend all them. Leaving the next subtests with no 0.001 UTXOs to spend.

  To solve it, this PR moves the recently added case into a "context independent subtests" section.
  Which is placed at the end to not affect other cases.

ACKs for top commit:
  achow101:
    ACK e07dd5f
  pablomartin4btc:
    ACK bitcoin@e07dd5f.

Tree-SHA512: c150ed6fcfbb6f1502eaf6370a57aae0da991c0fc48e8bb3d446805f4336abba5d80ff0de26094914da95432dd0255030fe527001af4510dfdcefbc7230f14d6
@coderabbitai
Copy link

coderabbitai bot commented Sep 30, 2025

Warning

Rate limit exceeded

@DashCoreAutoGuix has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 51 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 54e2588 and 88864ed.

📒 Files selected for processing (2)
  • doc/developer-notes.md (1 hunks)
  • test/functional/wallet_bumpfee.py (1 hunks)
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport-0.25-batch-412-pr-27471

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants