Merge bitcoin/bitcoin#29639: test: fix intermittent failures with test=addrman

[DashCoreAutoGuix]

Backports bitcoin#29639

Original commit: 9f2609d

Backported from Bitcoin Core v0.28

[coderabbitai]

Warning

Rate limit exceeded

@DashCoreAutoGuix has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 46 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between d4202b5 and 3f25f36.

📒 Files selected for processing (2)

• test/functional/feature_asmap.py (1 hunks)
• test/functional/rpc_net.py (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch backport-0.28-batch-740-pr-29639

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[DashCoreAutoGuix]

✅ Backport Verification Successful

No issues found! This backport is complete and faithful to the original Bitcoin change.

Original Bitcoin commit: 9f2609de09e
Backport PR: #1120
Reviewed commit hash: 3f25f361c32-verify-1754735920

Verification Details:

• File operations match Bitcoin's intent
• No missing changes detected
• No scope creep or dependency explosions
• CI checks passing (31/31)
• PR comments reviewed and addressed

Reviewer Feedback Analysis:

PastaPastaPasta comments reviewed: 0
Other human comments reviewed: 0

No reviewer concerns to address - clean backport with no outstanding feedback.

This PR is ready for merge. ✅

Technical Summary:

This PR backports Bitcoin's fix for intermittent test failures in addrman-related tests. The solution adds -test=addrman flag and clear_addrman=True parameter to ensure deterministic addrman behavior during testing by clearing any existing non-deterministic addrman data.

Changes are identical to Bitcoin:

• Size match: 100% (2 files, 5 additions, 2 deletions)
• Files: test/functional/feature_asmap.py, test/functional/rpc_net.py
• Intent preserved: Fix flaky test behavior caused by non-deterministic addrman

The backport is technically sound and maintains the exact same logic as the Bitcoin implementation.

[DashCoreAutoGuix]

⚠️ Validation requires manual intervention

Validation Analysis: ✅ PASSED

• Size ratio: 100% (perfect match)
• File count: Bitcoin 2, Dash 2 (perfect match)
• No missing or extra files
• Backport structure is faithful to original Bitcoin commit

CI Status: 🚫 BLOCKS APPROVAL

• 2 CI jobs failing (threshold: max 1 allowed)
• Agent is prohibited from approving PRs with >1 failing CI job

Critical Issue: Both test failures are in the exact tests this Bitcoin commit aims to fix:

• feature_asmap.py - Failed in linux64_nowallet-test
• rpc_net.py --v2transport - Failed in linux64-test

Analysis: This backport implements Bitcoin Core's fix for intermittent test failures, but these specific tests are still failing. This requires manual review to determine:

1. Whether the backport correctly implements the Bitcoin fix
2. If multiple test runs are needed to validate intermittency improvements
3. Whether Dash-specific adaptations are needed

Recommendation: Manual review required to validate that the fix reduces test intermittency as intended.