Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.overmind.env does not pass on existing defined variables #59

Closed
davidkarlsen opened this issue Sep 25, 2019 · 5 comments
Closed

.overmind.env does not pass on existing defined variables #59

davidkarlsen opened this issue Sep 25, 2019 · 5 comments

Comments

@davidkarlsen
Copy link

~$ cat .overmind.env 

# Can't use backslash to make it readable
DEFAULT_JAVA_OPTIONS="-Dapp=${APP} -Djava.net.preferIPv4Stack=true -Dcom.sun.management.jmxremote.authenticate=false -Dlogback.ContextSelector=JNDI -Dcom.sun.management.jmxremote.ssl=false -Xlog:gc*:file=logs/gc.log::filecount=5,filesize=10M -XX:+HeapDumpOnOutOfMemoryError -Djetty.requestlog.timezone=Europe/Oslo -Ddefault.client.encoding=UTF-8 -server"
app@eos-jfr-srv-d1-fsjetty-7c7d8c8d6-dspfw:~$ echo $APP
eos-jfr-srv-d1-fsjetty-7c7d8c8d6-dspfw
app@eos-jfr-srv-d1-fsjetty-7c7d8c8d6-dspfw:~$ ps xa|grep app=
    26 pts/1    Sl+    1:24 java -Dapp= -Djava.net.preferIPv4Stack=true -Dcom.sun.management.jmxremote.authenticate=false -Dlogback.ContextSelector=JNDI -Dcom.sun.management.jmxremote.ssl=f
   154 ?        S+     0:00 grep --color=auto app=
app@eos-jfr-srv-d1-fsjetty-7c7d8c8d6-dspfw:~$ 

notice how -Dapp= w/o the variable passed

@DarthSim
Copy link
Owner

DarthSim commented Oct 8, 2019

Hi,

Thanks for catching this. It's a bug in godotenv. I fixed it in my fork and temporary used it in master. I don't like the idea of releasing a new version until it's fixed in the main repo (there are PR joho/godotenv#72 is merged for this), but it looks I'll have to.

You can install the fixed version of overmind with go get.

@davidkarlsen
Copy link
Author

@DarthSim Hmm - that PR doesn't seem to have a lot of traction. Let's see what will happen - are there other alternative libraries which are better maintained?

@davidkarlsen
Copy link
Author

@DarthSim any thoughts on alternatives?

@davidkarlsen
Copy link
Author

@DarthSim This was fixed in latest release - wasn't it?

@DarthSim
Copy link
Owner

Yup. Sorry, I was tired as hell and didn't have a chance to mention the fix here. I decided to go with the forked version of godotenv.

Envek added a commit that referenced this issue Mar 6, 2024
Fixes #172

Use another fork to keep up-to-date fix for #59
(waiting for upstream pull request joho/godotenv#227 to be merged)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants