Skip to content

Commit

Permalink
Update .env.example, Update page metadata and descriptions, Update th…
Browse files Browse the repository at this point in the history
…eme color in meta tag, Refactor GET request in sitemap.xml server.ts, Remove microsoft-identity-association.json file, Update robots.txt to disallow certain paths and allow others, Update the contributing guide (#76)

This pull request includes several updates to the codebase:

- Updated the .env.example file with new environment variables.

- Updated the page metadata and descriptions for better SEO.

- Updated the theme color in the meta tag.

- Refactored the GET request in the sitemap.xml server.ts file.

- Removed the microsoft-identity-association.json file.

- Updated the robots.txt file to disallow certain paths and allow others.

- Updated the contributing guide.

These changes improve the functionality, performance, and maintainability of the project.
  • Loading branch information
DarthGigi authored Feb 2, 2024
2 parents 58917f7 + c62b35b commit 3d1bb63
Show file tree
Hide file tree
Showing 7 changed files with 27 additions and 42 deletions.
6 changes: 0 additions & 6 deletions .env.example
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
# Environment variables declared in this file are automatically made available to Prisma.
# See the documentation for more detail: https://pris.ly/d/prisma-schema#accessing-environment-variables-from-the-schema

# Prisma supports the native connection string format for PostgreSQL, MySQL, SQLite, SQL Server, MongoDB and CockroachDB.
# See the documentation for all the connection string options: https://pris.ly/d/connection-strings

# Database
# Prisma Accelerate
DATABASE_URL="prisma://accelerate.prisma-data.net/?api_key=__API_KEY__"
Expand Down
18 changes: 5 additions & 13 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ This section will guide you through the process of setting up the project for de
- [pnpm](https://pnpm.js.org/en/installation) (recommended)
- [MongoDB](https://www.mongodb.com/try/download/community) (v7.0 or higher) (this project uses MongoDB Atlas, but you can use a local instance if you want)
- [Vercel](https://vercel.com/) (this project uses Vercel for hosting and deployment, so your fork should be Vercel compatible)
- [Cloudinary](https://cloudinary.com/) (this project uses Cloudinary for image hosting, so you will need to create an account and get your cloud name, API key, and API secret)

## 🚀 Getting Started

Expand Down Expand Up @@ -68,22 +69,13 @@ This section will guide you through the process of setting up the project for de

This will get rid of TypeScript errors and warnings.

7. Open `src/routes/api/resetminions/+server.ts`, remove
7. Open [localhost:5173/signup](http://localhost:5173/signup) to make an account.

```js
return new Response(null, {
status: 302,
headers: {
location: "/"
}
});
```

at the top of the file, and open [localhost:5173/api/resetminions](http://localhost:5173/api/resetminions) with your browser to fill the database with all the Hypixel SkyBlock minions and their data.
8. After making an account, add your ID to the `ADMIN_ID` field in the `.env` file.

8. Done! You can now start making changes to the code and see them reflected in the browser.
9. Open [localhost:5173/dashboard/minions](http://localhost:5173/dashboard/minions), click the "Actions" button, and then click "Update every minion". This will add all the Hypixel SkyBlock minions to the database.

9. (Optional) You should probably make an account so you can work on stuff where you need to be logged in. You can do this by going to [localhost:5173/login](http://localhost:5173/login) and clicking the "Sign up" button.
10. Done! You can now start making changes to the code and see them reflected in the browser.

# 🔀 Pull Requests

Expand Down
18 changes: 9 additions & 9 deletions src/routes/(main)/+layout.svelte
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
<svelte:head>
<!-- Primary Meta Tags -->
<title>MinionAH The Auction House for Hypixel SkyBlock Minions</title>
<meta name="title" content="MinionAHThe Auction House for Hypixel SkyBlock Minions" />
<meta name="description" content="Buy and sell Hypixel SkyBlock minions easily on MinionAH. Explore a seamless marketplace with a beautiful interface for minion trading." />
<meta name="theme-color" content="#131313" />
<title>MinionAH - The Auction House for SkyBlock Minions</title>
<meta name="title" content="MinionAH: The Auction House for SkyBlock Minions" />
<meta name="description" content="MinionAH is the best place to trade Hypixel SkyBlock minions. Minion auction house has a modern design, has QOL features for trading skyblock minions, and more." />
<meta name="theme-color" content="#171717" />
<link rel="canonical" href="https://minionah.com" />
<meta name="keywords" content="MinionAH, Hypixel SkyBlock, minions, auction house, minion trading, skyblock auction, skyblock minions, Hypixel minions, buy minions, sell minions" />
<meta name="keywords" content="MinionAH, Hypixel SkyBlock, minions, auction house, minion trading, skyblock auction, skyblock minions, Hypixel minions, buy minions, sell minions, minionah, skyblock, minion ah, minion auctions, minion skyblock" />

<!-- Open Graph / Facebook -->
<meta property="og:type" content="website" />
<meta property="og:url" content="https://minionah.com" />
<meta property="og:title" content="MinionAHThe Auction House for Hypixel SkyBlock Minions" />
<meta property="og:description" content="Buy and sell Hypixel SkyBlock minions easily on MinionAH. Explore a seamless marketplace with a beautiful interface for minion trading." />
<meta property="og:title" content="MinionAH: The Auction House for SkyBlock Minions" />
<meta property="og:description" content="MinionAH is the best place to trade Hypixel SkyBlock minions. Minion auction house has a modern design, has QOL features for trading skyblock minions, and more." />
<meta property="og:image" content="https://minionah.com/assets/images/ogBanner.png?v=2" />
<meta property="og:image:secure_url" content="https://minionah.com/assets/images/ogBanner.png?v=2" />
<meta property="og:image:alt" content="MinionAH" />
Expand All @@ -24,8 +24,8 @@
<!-- Twitter -->
<meta property="twitter:card" content="summary_large_image" />
<meta property="twitter:url" content="https://minionah.com" />
<meta property="twitter:title" content="MinionAH" />
<meta property="twitter:description" content="Buy and sell Hypixel SkyBlock minions easily on MinionAH. Explore a seamless marketplace with a beautiful interface for minion trading." />
<meta property="twitter:title" content="MinionAH: The Auction House for SkyBlock Minions" />
<meta property="twitter:description" content="MinionAH is the best place to trade Hypixel SkyBlock minions. Minion auction house has a modern design, has QOL features for trading skyblock minions, and more." />
<meta property="twitter:image" content="https://minionah.com/assets/images/ogBanner.png?v=2" />
</svelte:head>
<slot />
2 changes: 1 addition & 1 deletion src/routes/api/craftcost/docs/+page.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
<meta name="keywords" content="RCC, Craft Cost, Raw Craft Cost, API, Documentation, MinionAH" />
<meta name="robots" content="index, follow" />
<meta name="author" content="DarthGigi" />
<meta name="theme-color" content="#1f2937" />
<meta name="theme-color" content="#171717" />
<meta name="twitter:card" content="summary_large_image" />
<meta name="twitter:site" content="@MinionAH" />
<meta name="twitter:creator" content="@iDarthGigi" />
Expand Down
4 changes: 2 additions & 2 deletions src/routes/sitemap.xml/+server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { error } from "@sveltejs/kit";

export const GET: RequestHandler = async () => {
try {
const { users, minions } = await Promise.all([
const [users, minions] = await Promise.all([
prisma.user.findMany({
select: {
username: true
Expand All @@ -20,7 +20,7 @@ export const GET: RequestHandler = async () => {
}
}
})
]).then(([users, minions]) => ({ users, minions }));
]);

return await sitemap.response({
origin: "https://minionah.com",
Expand Down
7 changes: 0 additions & 7 deletions static/.well-known/microsoft-identity-association.json

This file was deleted.

14 changes: 10 additions & 4 deletions static/robots.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
User-agent: *
Disallow: /api/
Disallow: /filter/
Disallow: /resetminions/
Disallow: /profile/
Disallow: /assets/css/
Disallow: /assets/fonts/
Disallow: /api/dashboard/
Disallow: /api/getColor/
Disallow: /api/loadMinions/
Disallow: /api/minionprice/
Disallow: /api/oauth/
Disallow: /api/craftcost/

Allow: /.well-known/
Allow: /
Allow: /assets/images/
Allow: /api/craftcost/docs/

Sitemap: https://minionah.com/sitemap.xml

0 comments on commit 3d1bb63

Please sign in to comment.