Skip to content

prevent doc generation when generate_always is false #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

prevent doc generation when generate_always is false #584

wants to merge 4 commits into from

Conversation

balajidharma
Copy link

No description provided.

gnovaro
gnovaro approved these changes May 6, 2024
View reviewed changes
Copy link

@gnovaro gnovaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

DarkaOnLine
DarkaOnLine reviewed Aug 9, 2024
View reviewed changes
Copy link
Owner

@DarkaOnLine DarkaOnLine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be a use case for this? If you run CLI comman to generate docs - you probably want them to be generated and not show error that some flag is off, no?

@balajidharma
Copy link
Author

balajidharma commented Aug 9, 2024 •
edited
Loading

What would be a use case for this? If you run CLI comman to generate docs - you probably want them to be generated and not show error that some flag is off, no?

Prevent the doc generation if we manually generated docs_yaml file from https://editor.swagger.io/.

@AlexDelPab
Copy link

IMHO this should be a separate flag then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkaOnLine DarkaOnLine DarkaOnLine left review comments

+2 more reviewers

@gnovaro gnovaro gnovaro approved these changes

@oteroweb oteroweb oteroweb approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@balajidharma @AlexDelPab @gnovaro @DarkaOnLine @oteroweb