Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barcode generator: rfct, ux improvements, implement EAN-8. #154

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

msvsergey
Copy link
Contributor

@msvsergey msvsergey commented Nov 7, 2022

What's new

  • Code is totally refactored (removed similar functions for every digit, increased readability by introducing enum and constants for view modes/menu items, other improvements).
  • Implemented EAN-8 (issue)
  • UX improvements: align elements, correctly handle ok and back buttons.

Verification

  • Make sure both UPC-A and EAN-8 are working correctly.

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@msvsergey msvsergey requested a review from xMasterX as a code owner November 7, 2022 15:42
Copy link
Member

@xMasterX xMasterX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tested fine, thanks for PR, thats a good improvement for this plugin

@xMasterX xMasterX merged commit 52650ab into DarkFlippers:dev Nov 10, 2022
@Bon-Jorik
Copy link
Contributor

Bon-Jorik commented Dec 21, 2022

Could you add EAN-13 type barcode gen? It's the most used for everything

@mhafizhandi
Copy link

Hi, just to feedback that Code-128 doesn't seems to work as it says 'Missing Encoding Table'
Missing Encoding Table

@xMasterX
Copy link
Member

Hi, just to feedback that Code-128 doesn't seems to work as it says 'Missing Encoding Table'
Missing Encoding Table

Wrong repo, there is no code 128 in this PR or in this whole repo

@mhafizhandi
Copy link

Hi, just to feedback that Code-128 doesn't seems to work as it says 'Missing Encoding Table'
Missing Encoding Table

Wrong repo, there is no code 128 in this PR or in this whole repo

Apologies my bad. yea, no Code-128 after a fresh update. was trying to save some of the cards to test on them. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants