Skip to content

Commit

Permalink
kbuild: clean up *.dtb and *.dtb.S patterns from top-level Makefile
Browse files Browse the repository at this point in the history
We need to add "clean-files" in Makfiles to clean up DT blobs, but we
often miss to do so.

Since there are no source files that end with .dtb or .dtb.S, so we
can clean-up those files from the top-level Makefile.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Rob Herring <robh@kernel.org>
  • Loading branch information
masahir0y authored and robherring committed Nov 8, 2017
1 parent 10b62a2 commit 74ce189
Show file tree
Hide file tree
Showing 54 changed files with 3 additions and 60 deletions.
1 change: 0 additions & 1 deletion Documentation/kbuild/makefiles.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1153,7 +1153,6 @@ When kbuild executes, the following steps are followed (roughly):

Example:
targets += $(dtb-y)
clean-files += *.dtb
DTC_FLAGS ?= -p 1024

--- 6.8 Custom kbuild commands
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -1544,7 +1544,7 @@ clean: $(clean-dirs)
$(call cmd,rmfiles)
@find $(if $(KBUILD_EXTMOD), $(KBUILD_EXTMOD), .) $(RCS_FIND_IGNORE) \
\( -name '*.[oas]' -o -name '*.ko' -o -name '.*.cmd' \
-o -name '*.ko.*' \
-o -name '*.ko.*' -o -name '*.dtb' -o -name '*.dtb.S' \
-o -name '*.dwo' \
-o -name '*.su' \
-o -name '.*.d' -o -name '.*.tmp' -o -name '*.mod.c' \
Expand Down
1 change: 0 additions & 1 deletion arch/arc/boot/dts/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,3 @@ dtstree := $(srctree)/$(src)
dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts))

always := $(dtb-y)
clean-files := *.dtb *.dtb.S
1 change: 0 additions & 1 deletion arch/arm/boot/dts/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -1074,4 +1074,3 @@ dtstree := $(srctree)/$(src)
dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts))

always := $(dtb-y)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/actions/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@ dtb-$(CONFIG_ARCH_ACTIONS) += s900-bubblegum-96.dtb

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/al/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@ dtb-$(CONFIG_ARCH_ALPINE) += alpine-v2-evp.dtb

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/allwinner/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,3 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-nanopi-neo2.dtb

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/altera/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@ dtb-$(CONFIG_ARCH_STRATIX10) += socfpga_stratix10_socdk.dtb

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/amd/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@ dtb-$(CONFIG_ARCH_SEATTLE) += amd-overdrive.dtb \

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/amlogic/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,3 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxm-rbox-pro.dtb

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/apm/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@ dtb-$(CONFIG_ARCH_XGENE) += apm-merlin.dtb

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/arm/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,3 @@ dtb-$(CONFIG_ARCH_VEXPRESS) += vexpress-v2f-1xv7-ca53x2.dtb

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/broadcom/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@ dts-dirs += northstar2
dts-dirs += stingray
always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/broadcom/northstar2/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@ dtb-$(CONFIG_ARCH_BCM_IPROC) += ns2-xmc.dtb

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/broadcom/stingray/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@ dtb-$(CONFIG_ARCH_BCM_IPROC) += bcm958742t.dtb

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/cavium/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@ dtb-$(CONFIG_ARCH_THUNDER2) += thunder2-99xx.dtb

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/exynos/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,3 @@ dtb-$(CONFIG_ARCH_EXYNOS) += \

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/freescale/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,3 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-rdb.dtb

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/hisilicon/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,3 @@ dtb-$(CONFIG_ARCH_HISI) += hip07-d05.dtb

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/lg/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@ dtb-$(CONFIG_ARCH_LG1K) += lg1313-ref.dtb

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/marvell/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,3 @@ dtb-$(CONFIG_ARCH_MVEBU) += armada-8080-db.dtb

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/mediatek/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,3 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/nvidia/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,3 @@ dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-smaug.dtb
dtb-$(CONFIG_ARCH_TEGRA_186_SOC) += tegra186-p2771-0000.dtb

always := $(dtb-y)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/qcom/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,3 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8996-mtp.dtb

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/realtek/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@ dtb-$(CONFIG_ARCH_REALTEK) += rtd1295-zidoo-x9s.dtb

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/renesas/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,3 @@ dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-salvator-x.dtb r8a7796-m3ulcb.dtb
dtb-$(CONFIG_ARCH_R8A77995) += r8a77995-draak.dtb

always := $(dtb-y)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/rockchip/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,3 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-sapphire-excavator.dtb

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/socionext/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,3 @@ dtb-$(CONFIG_ARCH_UNIPHIER) += \
uniphier-pxs3-ref.dtb

always := $(dtb-y)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/sprd/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@ dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb \

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/xilinx/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@ dtb-$(CONFIG_ARCH_ZYNQMP) += zynqmp-ep108.dtb

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
1 change: 0 additions & 1 deletion arch/arm64/boot/dts/zte/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@ dtb-$(CONFIG_ARCH_ZX) += zx296718-pcbox.dtb

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb
2 changes: 0 additions & 2 deletions arch/c6x/boot/dts/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,3 @@ $(obj)/builtin.dtb: $(obj)/$(DTB).dtb
$(call if_changed,cp)

$(obj)/linked_dtb.o: $(obj)/builtin.dtb

clean-files := *.dtb
2 changes: 0 additions & 2 deletions arch/cris/boot/dts/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,3 @@ BUILTIN_DTB := $(patsubst "%",%,$(CONFIG_BUILTIN_DTB)).dtb.o
ifneq ($(CONFIG_BUILTIN_DTB),"")
obj-$(CONFIG_OF) += $(BUILTIN_DTB)
endif

clean-files := *.dtb.S
1 change: 0 additions & 1 deletion arch/h8300/boot/dts/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,3 @@ dtstree := $(srctree)/$(src)
dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts))

always := $(dtb-y)
clean-files := *.dtb.S *.dtb
1 change: 0 additions & 1 deletion arch/metag/boot/dts/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,3 @@ dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dts
.SECONDARY: $(obj)/$(builtindtb-y).dtb.S

always += $(dtb-y)
clean-files += *.dtb *.dtb.S
2 changes: 1 addition & 1 deletion arch/microblaze/boot/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ $(obj)/simpleImage.%: vmlinux FORCE
$(call if_changed,strip)
@echo 'Kernel: $@ is ready' ' (#'`cat .version`')'

clean-files += simpleImage.*.unstrip linux.bin.ub dts/*.dtb
clean-files += simpleImage.*.unstrip linux.bin.ub
1 change: 0 additions & 1 deletion arch/mips/boot/dts/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,3 @@ dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(foreach d,$(dt

always := $(dtb-y)
subdir-y := $(dts-dirs)
clean-files := *.dtb *.dtb.S
1 change: 0 additions & 1 deletion arch/mips/boot/dts/brcm/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,3 @@ obj-y += $(patsubst %.dtb, %.dtb.o, $(dtb-y))
obj- += dummy.o

always := $(dtb-y)
clean-files := *.dtb *.dtb.S
1 change: 0 additions & 1 deletion arch/mips/boot/dts/cavium-octeon/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,3 @@ obj-y += $(patsubst %.dtb, %.dtb.o, $(dtb-y))
obj- += dummy.o

always := $(dtb-y)
clean-files := *.dtb *.dtb.S
1 change: 0 additions & 1 deletion arch/mips/boot/dts/img/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,3 @@ obj-$(CONFIG_MACH_PISTACHIO) += pistachio_marduk.dtb.o
obj- += dummy.o

always := $(dtb-y)
clean-files := *.dtb *.dtb.S
1 change: 0 additions & 1 deletion arch/mips/boot/dts/ingenic/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,3 @@ obj-y += $(patsubst %.dtb, %.dtb.o, $(dtb-y))
obj- += dummy.o

always := $(dtb-y)
clean-files := *.dtb *.dtb.S
1 change: 0 additions & 1 deletion arch/mips/boot/dts/lantiq/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,3 @@ obj-y += $(patsubst %.dtb, %.dtb.o, $(dtb-y))
obj- += dummy.o

always := $(dtb-y)
clean-files := *.dtb *.dtb.S
1 change: 0 additions & 1 deletion arch/mips/boot/dts/mti/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,3 @@ obj-y += $(patsubst %.dtb, %.dtb.o, $(dtb-y))
obj- += dummy.o

always := $(dtb-y)
clean-files := *.dtb *.dtb.S
1 change: 0 additions & 1 deletion arch/mips/boot/dts/netlogic/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,3 @@ obj-y += $(patsubst %.dtb, %.dtb.o, $(dtb-y))
obj- += dummy.o

always := $(dtb-y)
clean-files := *.dtb *.dtb.S
1 change: 0 additions & 1 deletion arch/mips/boot/dts/ni/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@ dtb-$(CONFIG_FIT_IMAGE_FDT_NI169445) += 169445.dtb
obj- += dummy.o

always := $(dtb-y)
clean-files := *.dtb *.dtb.S
1 change: 0 additions & 1 deletion arch/mips/boot/dts/pic32/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,3 @@ obj-y += $(patsubst %.dtb, %.dtb.o, $(dtb-y))
obj- += dummy.o

always := $(dtb-y)
clean-files := *.dtb *.dtb.S
1 change: 0 additions & 1 deletion arch/mips/boot/dts/qca/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,3 @@ dtb-$(CONFIG_ATH79) += ar9331_tl_mr3020.dtb
obj- += dummy.o

always := $(dtb-y)
clean-files := *.dtb *.dtb.S
1 change: 0 additions & 1 deletion arch/mips/boot/dts/ralink/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,3 @@ obj-y += $(patsubst %.dtb, %.dtb.o, $(dtb-y))
obj- += dummy.o

always := $(dtb-y)
clean-files := *.dtb *.dtb.S
1 change: 0 additions & 1 deletion arch/mips/boot/dts/xilfpga/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,3 @@ obj-y += $(patsubst %.dtb, %.dtb.o, $(dtb-y))
obj- += dummy.o

always := $(dtb-y)
clean-files := *.dtb *.dtb.S
2 changes: 0 additions & 2 deletions arch/nios2/boot/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,5 @@ $(obj)/%.dtb: $(src)/dts/%.dts FORCE

$(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y))

clean-files := *.dtb

install:
sh $(srctree)/$(src)/install.sh $(KERNELRELEASE) $(BOOTIMAGE) System.map "$(INSTALL_PATH)"
2 changes: 0 additions & 2 deletions arch/openrisc/boot/dts/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,4 @@ BUILTIN_DTB :=
endif
obj-y += $(BUILTIN_DTB)

clean-files := *.dtb.S

#DTC_FLAGS ?= -p 1024
2 changes: 1 addition & 1 deletion arch/powerpc/boot/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ zInstall: $(CONFIGURE) $(addprefix $(obj)/, $(image-y))
clean-files += $(image-) $(initrd-) cuImage.* dtbImage.* treeImage.* \
zImage zImage.initrd zImage.chrp zImage.coff zImage.holly \
zImage.miboot zImage.pmac zImage.pseries \
zImage.maple simpleImage.* otheros.bld *.dtb
zImage.maple simpleImage.* otheros.bld

# clean up files cached by wrapper
clean-kernel-base := vmlinux.strip vmlinux.bin
Expand Down
2 changes: 0 additions & 2 deletions arch/sh/boot/dts/Makefile
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
obj-$(CONFIG_USE_BUILTIN_DTB) += $(patsubst "%",%,$(CONFIG_BUILTIN_DTB_SOURCE)).dtb.o

clean-files := *.dtb.S
2 changes: 0 additions & 2 deletions arch/xtensa/boot/dts/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,3 @@ dtstree := $(srctree)/$(src)
dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts))

always += $(dtb-y)
clean-files += *.dtb *.dtb.S

0 comments on commit 74ce189

Please sign in to comment.