Skip to content

Commit

Permalink
video: fbdev: tgafb: Fix kernel-doc and set but not used warnings
Browse files Browse the repository at this point in the history
Fix W=1 warnings:
- Fix kernel-doc
- Drop unused code

v2:
  - Updated subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Joe Perches <joe@perches.com>
Cc: Lee Jones <lee.jones@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20201128224114.1033617-18-sam@ravnborg.org
  • Loading branch information
sravnborg committed Nov 30, 2020
1 parent b47e6ca commit 2f71315
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions drivers/video/fbdev/tgafb.c
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ tgafb_setcolreg(unsigned regno, unsigned red, unsigned green, unsigned blue,

/**
* tgafb_blank - Optional function. Blanks the display.
* @blank_mode: the blank mode we want.
* @blank: the blank mode we want.
* @info: frame buffer structure that represents a single frame buffer
*/
static int
Expand Down Expand Up @@ -837,7 +837,7 @@ tgafb_clut_imageblit(struct fb_info *info, const struct fb_image *image)
u32 *palette = ((u32 *)info->pseudo_palette);
unsigned long pos, line_length, i, j;
const unsigned char *data;
void __iomem *regs_base, *fb_base;
void __iomem *fb_base;

dx = image->dx;
dy = image->dy;
Expand All @@ -855,7 +855,6 @@ tgafb_clut_imageblit(struct fb_info *info, const struct fb_image *image)
if (dy + height > vyres)
height = vyres - dy;

regs_base = par->tga_regs_base;
fb_base = par->tga_fb_base;

pos = dy * line_length + (dx * 4);
Expand Down Expand Up @@ -1034,7 +1033,7 @@ tgafb_fillrect(struct fb_info *info, const struct fb_fillrect *rect)
regs_base + TGA_MODE_REG);
}

/**
/*
* tgafb_copyarea - REQUIRED function. Can use generic routines if
* non acclerated hardware and packed pixel based.
* Copies on area of the screen to another area.
Expand Down

0 comments on commit 2f71315

Please sign in to comment.