Skip to content

Commit

Permalink
kallsyms: Use bounded strnchr() when parsing string
Browse files Browse the repository at this point in the history
When parsing for the <module:name> format, we use strchr() to look for
the separator, when we know that the module name can't be longer than
MODULE_NAME_LEN. Enforce the same using strnchr().

Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Jessica Yu <jeyu@redhat.com>
  • Loading branch information
rnav authored and Jessica Yu committed Apr 24, 2017
1 parent 8ba4fcd commit 1758618
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -4017,7 +4017,7 @@ unsigned long module_kallsyms_lookup_name(const char *name)

/* Don't lock: we're in enough trouble already. */
preempt_disable();
if ((colon = strchr(name, ':')) != NULL) {
if ((colon = strnchr(name, MODULE_NAME_LEN, ':')) != NULL) {
if ((mod = find_module_all(name, colon - name, false)) != NULL)
ret = mod_find_symname(mod, colon+1);
} else {
Expand Down

0 comments on commit 1758618

Please sign in to comment.