Snyk upgrade 5dbbfe916d9e59ac921bf670e04c7c17#569
Conversation
Bumps [shiki](https://github.com/shikijs/shiki/tree/HEAD/packages/shiki) from 1.27.0 to 2.3.2. - [Release notes](https://github.com/shikijs/shiki/releases) - [Commits](https://github.com/shikijs/shiki/commits/v2.3.2/packages/shiki) --- updated-dependencies: - dependency-name: shiki dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Create codeql.yml
….3.2 build(deps): bump shiki from 1.27.0 to 2.3.2
Snyk has created this PR to upgrade @aws-sdk/credential-providers from 3.592.0 to 3.734.0. See this package in npm: @aws-sdk/credential-providers See this project in Snyk: https://app.snyk.io/org/dargon789/project/e7fa878f-9d48-45bd-a72d-921183752fef?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade @aws-sdk/client-kms from 3.592.0 to 3.734.0. See this package in npm: @aws-sdk/client-kms See this project in Snyk: https://app.snyk.io/org/dargon789/project/e7fa878f-9d48-45bd-a72d-921183752fef?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade posthog-js from 1.67.1 to 1.210.2. See this package in npm: posthog-js See this project in Snyk: https://app.snyk.io/org/dargon789/project/a19f499f-38be-44a8-b151-119edbfc95d2?utm_source=github&utm_medium=referral&page=upgrade-pr
…4c4b9f07bf4053 [Snyk] Upgrade posthog-js from 1.67.1 to 1.210.2
…d88b5ff5e05074 [Snyk] Upgrade @aws-sdk/credential-providers from 3.592.0 to 3.734.0
…ca964e62a741c1 [Snyk] Upgrade @aws-sdk/client-kms from 3.592.0 to 3.734.0
Snyk has created this PR to upgrade @google/model-viewer from 2.1.1 to 4.0.0. See this package in npm: @google/model-viewer See this project in Snyk: https://app.snyk.io/org/dargon789/project/b2aa4281-7627-443a-bbf2-b110a878f4b9?utm_source=github&utm_medium=referral&page=upgrade-pr
There was a problem hiding this comment.
Sorry @Dargon789, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on a comprehensive dependency upgrade across the project's applications and packages, ensuring the codebase leverages the latest features and security patches. Concurrently, it introduces significant enhancements to the marketplace functionalities, particularly for English Auctions and Direct Listings, by adding new utility functions and extensive test coverage. Furthermore, the PR expands the testing suite to cover various RPC actions and internal utilities, improving the overall stability and maintainability of the project. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request primarily consists of dependency upgrades and a significant number of additions and improvements to the test suite. The changes enhance test coverage and refactor some test files for better performance and organization. I've identified a few areas for improvement, including a commented-out test, a TODO for missing validation, some test code duplication, and minor inconsistencies in test implementations. Overall, the changes are positive and improve the robustness of the codebase.
packages/thirdweb/src/extensions/marketplace/direct-listings/direct-listings.test.ts
Outdated
Show resolved
Hide resolved
packages/thirdweb/src/extensions/marketplace/direct-listings/direct-listings.test.ts
Outdated
Show resolved
Hide resolved
packages/thirdweb/src/extensions/marketplace/english-auctions/english-auctions.test.ts
Outdated
Show resolved
Hide resolved
packages/thirdweb/src/extensions/marketplace/english-auctions/write/createAuction.ts
Outdated
Show resolved
Hide resolved
packages/thirdweb/src/rpc/actions/eth_getTransactionByHash.test.ts
Outdated
Show resolved
Hide resolved
…irect-listings.test.ts Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
…irect-listings.test.ts Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
…t.ts Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
…://github.com/Dargon789/thirdweb into snyk-upgrade-5dbbfe916d9e59ac921bf670e04c7c17
No description provided.