Skip to content

[Snyk] Security upgrade happy-dom from 17.4.4 to 20.0.0 #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dargon789 merged 1 commit into from
Oct 21, 2025
Merged

[Snyk] Security upgrade happy-dom from 17.4.4 to 20.0.0 #367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/thirdweb/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"ethers6": "npm:ethers@6",
"expo-linking": "7.0.5",
"expo-web-browser": "14.0.2",
"happy-dom": "17.4.4",
"happy-dom": "20.0.0",
Copy link

@gemini-code-assist gemini-code-assist bot Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This is a major version upgrade from v17 to v20. The Snyk metadata for this PR also indicates isBreakingChange:true. Such a large version jump for a testing environment like happy-dom has a high probability of introducing breaking changes that will cause tests to fail. Before merging, it is critical to run the full test suite and resolve any failures to avoid breaking the main branch.

"knip": "5.60.2",
"msw": "2.7.5",
"prettier": "3.6.2",
Expand Down
Loading